Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 542713002: Handle font-weigths with 'bolder' or 'lighter' values in @font-face rules (Closed)

Created:
6 years, 3 months ago by reni
Modified:
6 years, 3 months ago
Reviewers:
Timothy Loh, eae
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Handle font-weigths with 'bolder' or 'lighter' values in @font-face rules 'bolder' and 'lighter' values are valid keywords for font-weights except if they are inside @font-face rules. The patch catches such cases. (http://www.w3.org/TR/css3-fonts/#descdef-font-weight) R=eae@chromium.org BUG=410884 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181412

Patch Set 1 #

Patch Set 2 : Comment is added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
A LayoutTests/fast/css/font-face-with-lighter-or-bolder-weight-crash.html View 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/font-face-with-lighter-or-bolder-weight-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/FontFace.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
reni
The failing linux trybot is unrelated to this patch.
6 years, 3 months ago (2014-09-04 18:01:29 UTC) #2
eae
On 2014/09/04 18:01:29, reni wrote: > The failing linux trybot is unrelated to this patch. ...
6 years, 3 months ago (2014-09-04 18:36:45 UTC) #3
reni
6 years, 3 months ago (2014-09-04 18:47:10 UTC) #4
eae
Thanks, LGTM
6 years, 3 months ago (2014-09-04 18:55:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/542713002/20001
6 years, 3 months ago (2014-09-04 18:56:34 UTC) #7
reni
On 2014/09/04 18:55:52, eae wrote: > Thanks, LGTM Thanks!
6 years, 3 months ago (2014-09-04 19:44:21 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 23:01:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181412

Powered by Google App Engine
This is Rietveld 408576698