Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 542703002: Change ownership of the parameters to ServiceWorkerCache:: Put and Match. (Closed)

Created:
6 years, 3 months ago by jkarlin
Modified:
6 years, 3 months ago
Reviewers:
michaeln, michaeln1
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@keys
Project:
chromium
Visibility:
Public.

Description

Change ownership of the parameters to ServiceWorkerCache:: Put and Match. These functions used to take unowned raw pointers as arguments. Now the functions own them and they're scoped_ptrs. This both makes ownership clearer and allows for the functions to terminate early without calling their callbacks (needed for a downstream change to run CreateBackend lazily). Related CLs: * 1. https://crrev.com/542703002: Change ownership of the parameters to ServiceWorkerCache:: Put and Match. 2. https://crrev.com/545533002: Move ServiceWorkerCache backend creation to a lazy init function. 3. https://crrev.com/548533002: Make ServiceWorkerCacheStorage::CacheLoader::LoadCache synchronous 4. https://crrev.com/549493002: Expose ServiceWorkerCache objects to ServiceWorkerCacheStorageManager clients. BUG=392621 Committed: https://crrev.com/9f0f48cb851f273478579c14b3059acc8009b295 Cr-Commit-Position: refs/heads/master@{#294366}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -109 lines) Patch
M content/browser/service_worker/service_worker_cache.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 1 2 18 chunks +44 lines, -35 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_unittest.cc View 1 2 11 chunks +87 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jkarlin
Please take a look at everything, thanks!
6 years, 3 months ago (2014-09-05 16:09:07 UTC) #2
michaeln1
lgtm
6 years, 3 months ago (2014-09-05 22:43:51 UTC) #3
michaeln
wth... lgtm 2
6 years, 3 months ago (2014-09-11 00:48:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/542703002/40001
6 years, 3 months ago (2014-09-11 09:23:18 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 1d772124f2455d469520aeede63a32f487b46981
6 years, 3 months ago (2014-09-11 10:20:58 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 10:24:56 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9f0f48cb851f273478579c14b3059acc8009b295
Cr-Commit-Position: refs/heads/master@{#294366}

Powered by Google App Engine
This is Rietveld 408576698