Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1761)

Issue 542673002: Revert "Certificate Transparency: Code for unpacking EV cert hashes whitelist" (Closed)

Created:
6 years, 3 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
Eran Messeri
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Certificate Transparency: Code for unpacking EV cert hashes whitelist" This reverts commit 743f614e8b1daec08613e6108a6b2b902d5b9b55. It breaks X509CertificateTest.SHA256FingerprintsCorrectly on Vista. BUG=339128 TBR=eranm@chromium.org NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/87bf0f714ed33c50a109dc587c6a0e93a7f5d0e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -559 lines) Patch
D net/cert/ct_ev_whitelist.h View 1 chunk +0 lines, -93 lines 0 comments Download
D net/cert/ct_ev_whitelist.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D net/cert/ct_ev_whitelist_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M net/cert/x509_certificate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/cert/x509_certificate_ios.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/cert/x509_certificate_mac.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M net/cert/x509_certificate_nss.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M net/cert/x509_certificate_openssl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M net/cert/x509_certificate_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/cert/x509_certificate_win.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M net/net.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
Committed patchset #1 (id:1) manually as 87bf0f7 (presubmit successful).
6 years, 3 months ago (2014-09-04 15:11:52 UTC) #1
Eran Messeri
Is there a link to a trybot failure of this test? I'll note that the ...
6 years, 3 months ago (2014-09-04 15:50:04 UTC) #2
Eran Messeri
On 2014/09/04 15:50:04, Eran wrote: > Is there a link to a trybot failure of ...
6 years, 3 months ago (2014-09-04 16:37:46 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87bf0f714ed33c50a109dc587c6a0e93a7f5d0e3
Cr-Commit-Position: refs/heads/master@{#293300}

Powered by Google App Engine
This is Rietveld 408576698