Issue 542613003: Introduce code stub constructors for stub keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542613003: Introduce code stub constructors for stub keys. (Closed)

Created:
6 years, 3 months ago by Yang

Modified:
6 years, 3 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Introduce code stub constructors for stub keys. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23716

Patch Set 2 : define MajorKey inline #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -269 lines)			Patch
M	src/arm/code-stubs-arm.h	View	1	8 chunks	+7 lines, -13 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.h	View	1	7 chunks	+8 lines, -15 lines	0 comments	Download
M	src/code-stubs.h	View	1	85 chunks	+105 lines, -223 lines	0 comments	Download
M	src/code-stubs.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	1	5 chunks	+5 lines, -6 lines	0 comments	Download
M	src/ic/ic.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.h	View	1	6 chunks	+5 lines, -7 lines	0 comments	Download
M	test/cctest/test-code-stubs.cc	View	1	1 chunk	+16 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

lgtm https://codereview.chromium.org/542613003/diff/20001/test/cctest/test-code-stubs.cc File test/cctest/test-code-stubs.cc (right): https://codereview.chromium.org/542613003/diff/20001/test/cctest/test-code-stubs.cc#newcode178 test/cctest/test-code-stubs.cc:178: CcTest::InitializeVM(); Yay! nice test :).

6 years, 3 months ago (2014-09-04 14:24:00 UTC) #2

Yang

6 years, 3 months ago (2014-09-05 07:44:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 23716 (presubmit successful).

Expand Messages | Collapse Messages

Issue 542613003: Introduce code stub constructors for stub keys. (Closed)

Description

Patch Set 1 #

Patch Set 2 : define MajorKey inline #

Messages