[DirectWrite] Add support for font-weight suffixes

[DirectWrite] Add support for font-weight suffixes

Add support for font family names with a font-weight suffix (such as
Light, Semibold, Black  etc). If the full name fails to match an 
installed font check for a font-weight suffix and if so strip it and set
the weight according to the prefix.

The current implementation matches IE when it comes to picking or
overriding the weight based on the suffix.

TEST=fast/text/font-weight-variant.html
BUG=335323, 410333, 410865, 408260
R=cpu@chromium.org, dglazkov@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181493

[eae, 2014-09-05 21:37:03]

eae@chromium.org changed reviewers:
+ cpu@chromium.org, dglazkov@chromium.org

[eae, 2014-09-05 21:37:20]

Patchset #1 (id:1) has been deleted

[cpu_(ooo_6.6-7.5), 2014-09-05 22:23:27]

lgtm

https://codereview.chromium.org/542603004/diff/20001/Source/platform/fonts/wi...
File Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):

https://codereview.chromium.org/542603004/diff/20001/Source/platform/fonts/wi...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:227: { L" heavy", 6, 
FontWeight900 }
I don't know the customs of this land, but I would like to know where does the
200, 300, 600 numbers come from in a comment.

https://codereview.chromium.org/542603004/diff/20001/Source/platform/fonts/wi...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:232: FamilyVariantSuffix entry =
variantForSuffix[i];
const FamilyVariantSuffix& entry ?

https://codereview.chromium.org/542603004/diff/20001/Source/platform/fonts/wi...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:235:
familyName.truncate(family.length() - entry.length);
just to confirm String is mutable, as in truncate() changes it, instead of
returning a truncated one. Again I am unfamiliar with these lands.

[eae, 2014-09-05 22:32:05]

Thanks Carlos!

https://codereview.chromium.org/542603004/diff/20001/Source/platform/fonts/wi...
File Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):

https://codereview.chromium.org/542603004/diff/20001/Source/platform/fonts/wi...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:227: { L" heavy", 6, 
FontWeight900 }
On 2014/09/05 22:23:26, cpu wrote:
> I don't know the customs of this land, but I would like to know where does the
> 200, 300, 600 numbers come from in a comment.

Good idea, added a comment and a link.

https://codereview.chromium.org/542603004/diff/20001/Source/platform/fonts/wi...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:232: FamilyVariantSuffix entry =
variantForSuffix[i];
On 2014/09/05 22:23:26, cpu wrote:
> const FamilyVariantSuffix& entry ?

Done.

https://codereview.chromium.org/542603004/diff/20001/Source/platform/fonts/wi...
Source/platform/fonts/win/FontCacheSkiaWin.cpp:235:
familyName.truncate(family.length() - entry.length);
On 2014/09/05 22:23:26, cpu wrote:
> just to confirm String is mutable, as in truncate() changes it, instead of
> returning a truncated one. Again I am unfamiliar with these lands.

Correct, truncate mutates the string and is defined as "void truncate(unsigned
len);".

[eae, 2014-09-05 22:33:07]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-09-05 22:33:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eae@chromium.org/542603004/40001

[commit-bot: I haz the power, 2014-09-06 04:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 04:34:30]

Exceeded time limit waiting for builds to trigger.

[eae, 2014-09-06 15:03:51]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-09-06 15:04:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eae@chromium.org/542603004/40001

[commit-bot: I haz the power, 2014-09-06 15:05:22]

Committed patchset #2 (id:40001) as 181493