Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 542573002: Make onFileTransferUpdated single value from list. (Closed)

Created:
6 years, 3 months ago by iseki
Modified:
6 years, 3 months ago
Reviewers:
Finnur, hirono, hashimoto
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make onFileTransferUpdated single value from list. * SendDriveFileTransferEvent and onFileTransfersUpdated are not necessay to recieve list because this event is always single. BUG=408482 TEST=manually 1. Copy the local file to drive. 2. Confirm sync status is updated correctly. Committed: https://crrev.com/4a530823516e6278f74a898189bf5cc641d9e2f9 Cr-Commit-Position: refs/heads/master@{#293619}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -48 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M chrome/common/extensions/api/file_browser_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/drive_sync_handler.js View 1 chunk +15 lines, -19 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 1 chunk +10 lines, -16 lines 0 comments Download

Messages

Total messages: 29 (8 generated)
iseki
Please take a look.
6 years, 3 months ago (2014-09-04 08:23:17 UTC) #2
hirono
On 2014/09/04 08:23:17, iseki wrote: > Please take a look. Please update file_manager.js also.
6 years, 3 months ago (2014-09-04 08:36:29 UTC) #3
iseki
Thank you for your information. I modify file_manager.js.
6 years, 3 months ago (2014-09-04 08:43:55 UTC) #4
hirono
lgtm
6 years, 3 months ago (2014-09-04 08:48:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/542573002/20001
6 years, 3 months ago (2014-09-04 09:02:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8645)
6 years, 3 months ago (2014-09-04 09:16:22 UTC) #9
iseki
Please take a look. sky@ chrome/browser/chromeos/extensions/file_manager/event_router.cc chrome/common/extensions/api/file_browser_private.idl
6 years, 3 months ago (2014-09-04 11:35:57 UTC) #11
sky
I'm not a good reviewer for either of those files. Is there a better reviewer ...
6 years, 3 months ago (2014-09-04 17:39:04 UTC) #13
sky
I'm not a good reviewer for either of those files. Is there a better reviewer ...
6 years, 3 months ago (2014-09-04 17:39:05 UTC) #14
sky
I'm not a good reviewer for either of those files. Is there a better reviewer ...
6 years, 3 months ago (2014-09-04 17:39:05 UTC) #15
sky
I'm not a good reviewer for either of those files. Is there a better reviewer ...
6 years, 3 months ago (2014-09-04 17:39:06 UTC) #16
sky
On 2014/09/04 17:39:06, sky wrote: > I'm not a good reviewer for either of those ...
6 years, 3 months ago (2014-09-04 17:39:23 UTC) #17
iseki
sky@ Thank you.
6 years, 3 months ago (2014-09-04 23:18:25 UTC) #18
iseki
Please take a look. Finnur@ chrome/common/extensions/api/file_browser_private.idl hashimoto@ chrome/browser/chromeos/extensions/file_manager/event_router.cc
6 years, 3 months ago (2014-09-04 23:20:03 UTC) #19
hashimoto
event_router.cc lgtm
6 years, 3 months ago (2014-09-05 02:50:06 UTC) #20
Finnur
file_browser_private.idl LGTM
6 years, 3 months ago (2014-09-05 09:58:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/542573002/20001
6 years, 3 months ago (2014-09-06 02:31:38 UTC) #23
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 08:34:21 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/542573002/20001
6 years, 3 months ago (2014-09-06 14:59:02 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9560a421a56842385aa819810d5f9d22fcc1d668
6 years, 3 months ago (2014-09-06 18:31:57 UTC) #28
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:45 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a530823516e6278f74a898189bf5cc641d9e2f9
Cr-Commit-Position: refs/heads/master@{#293619}

Powered by Google App Engine
This is Rietveld 408576698