Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 542493002: Cleanup BrowserActionsContainer a bit (Closed)

Created:
6 years, 3 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
Finnur, sky
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup BrowserActionsContainer a bit Simple cleanup to remove unneeded parts of BrowserActionsContainer and friends. No behavioral changes, and nothing fancy. Committed: https://crrev.com/11fa81a03347b005afaf86ce20bc0808c34b6224 Cr-Commit-Position: refs/heads/master@{#293445}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : +DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -78 lines) Patch
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 1 9 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 7 chunks +4 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 5 chunks +6 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Devlin
Hey Finnur and Scott, hopefully this one's easy to review. :) Cheers!
6 years, 3 months ago (2014-09-04 15:43:12 UTC) #3
Finnur
LGTM
6 years, 3 months ago (2014-09-04 16:03:56 UTC) #4
sky
LGTM https://codereview.chromium.org/542493002/diff/20001/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc File chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc (right): https://codereview.chromium.org/542493002/diff/20001/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc#newcode261 chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc:261: return owner_->VisibleBrowserActions() + id - 1; DCHECK_GT(owner_->VisibleBrowserActions() + ...
6 years, 3 months ago (2014-09-04 17:53:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/542493002/40001
6 years, 3 months ago (2014-09-05 00:27:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001) as da8ad3d52c06dc543dc13624abb30944ac97efef
6 years, 3 months ago (2014-09-05 05:02:10 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:02 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/11fa81a03347b005afaf86ce20bc0808c34b6224
Cr-Commit-Position: refs/heads/master@{#293445}

Powered by Google App Engine
This is Rietveld 408576698