net/proxy/proxy_config_service_mac.h - Issue 542473002: Uses ProxyConfigServiceLinux in the chromoting host to configure proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_config_service_mac.h

Issue 542473002: Uses ProxyConfigServiceLinux in the chromoting host to configure proxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_config_service_mac.h

diff --git a/net/proxy/proxy_config_service_mac.h b/net/proxy/proxy_config_service_mac.h

index fe5ce30c0580afd7882ba0e7acd7be39773d8caa..6c11c6f0981d9abf7b0562fbdfe9aa4622d13599 100644

--- a/net/proxy/proxy_config_service_mac.h

+++ b/net/proxy/proxy_config_service_mac.h

@@ -20,10 +20,7 @@ class SingleThreadTaskRunner;

namespace net {

-// TODO(sergeyu): This class needs to be exported because remoting code

-// creates it directly. Fix that and remove NET_EXPORT here.

-// crbug.com/125104

-class NET_EXPORT ProxyConfigServiceMac : public ProxyConfigService {

+class ProxyConfigServiceMac : public ProxyConfigService {

public:

// Constructs a ProxyConfigService that watches the Mac OS system settings.

// This instance is expected to be operated and deleted on the same thread

« no previous file with comments | « no previous file | remoting/base/url_request_context_getter.h » ('j') | remoting/base/url_request_context_getter.cc » ('J')