Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 542473002: Uses ProxyConfigServiceLinux in the chromoting host to configure proxy. (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
mmenke, Jamie
CC:
chromium-reviews, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use ProxyConfigServiceLinux in the chromoting host to configure proxy. Previously chromoting host wasn't using proxies on linux because ProxyConfigServiceLinux doesn't work in NPAPI plugins. Now it's not a problem because we no longer support NPAPI. BUG=410521, 125104 R=jamiewalch@chromium.org, mmenke@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2eea434809cdc785f80a1281bea5e634a2cb474c

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -82 lines) Patch
M net/proxy/proxy_config_service_mac.h View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/base/url_request_context_getter.h View 1 chunk +7 lines, -8 lines 0 comments Download
M remoting/base/url_request_context_getter.cc View 1 chunk +6 lines, -62 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/chromoting_host_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_main.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download
M remoting/host/setup/start_host.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
Sergey Ulanov
This CL depends on https://codereview.chromium.org/540593002/ . mmenke - please approve net/* jamiewalch - please review
6 years, 3 months ago (2014-09-03 22:51:07 UTC) #2
mmenke
LGTM https://codereview.chromium.org/542473002/diff/20001/remoting/base/url_request_context_getter.cc File remoting/base/url_request_context_getter.cc (left): https://codereview.chromium.org/542473002/diff/20001/remoting/base/url_request_context_getter.cc#oldcode42 remoting/base/url_request_context_getter.cc:42: return new net::ProxyConfigServiceWin(); So this was relying on ...
6 years, 3 months ago (2014-09-04 16:17:40 UTC) #3
Sergey Ulanov
On 2014/09/04 16:17:40, mmenke wrote: > LGTM > > https://codereview.chromium.org/542473002/diff/20001/remoting/base/url_request_context_getter.cc > File remoting/base/url_request_context_getter.cc (left): > ...
6 years, 3 months ago (2014-09-05 00:14:18 UTC) #4
Sergey Ulanov
Jamie: ping
6 years, 3 months ago (2014-09-05 00:15:07 UTC) #5
Jamie
I'm not sure how much value I can add to this review, since I don't ...
6 years, 3 months ago (2014-09-05 00:21:56 UTC) #6
Sergey Ulanov
On 2014/09/05 00:21:56, Jamie wrote: > I'm not sure how much value I can add ...
6 years, 3 months ago (2014-09-05 00:32:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/542473002/20001
6 years, 3 months ago (2014-09-05 17:01:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/63248) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/12730)
6 years, 3 months ago (2014-09-05 17:20:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/542473002/20001
6 years, 3 months ago (2014-09-05 18:47:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5804)
6 years, 3 months ago (2014-09-05 19:03:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/542473002/40001
6 years, 3 months ago (2014-09-05 19:40:38 UTC) #17
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 01:41:20 UTC) #19
Sergey Ulanov
Committed patchset #3 (id:40001) manually as 2eea434 (presubmit successful).
6 years, 3 months ago (2014-09-06 02:23:54 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:11 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2eea434809cdc785f80a1281bea5e634a2cb474c
Cr-Commit-Position: refs/heads/master@{#293602}

Powered by Google App Engine
This is Rietveld 408576698