Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 542463002: Cast: Make castv2 test work on perf bots (Closed)

Created:
6 years, 3 months ago by hubbe
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cast: Make castv2 test work on perf bots Since perf bots build in release mode, UNSHIPPED_TRACE doesn't work. BUG=356842 Committed: https://crrev.com/8c2e61cc5ee7ece1eb8c876fbc717fd1f7911bce Cr-Commit-Position: refs/heads/master@{#293280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
hubbe
6 years, 3 months ago (2014-09-03 22:10:39 UTC) #2
Ken Russell (switch to Gerrit)
lgtm
6 years, 3 months ago (2014-09-03 22:30:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/542463002/1
6 years, 3 months ago (2014-09-03 23:43:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1896)
6 years, 3 months ago (2014-09-04 02:31:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/542463002/1
6 years, 3 months ago (2014-09-04 03:12:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1987)
6 years, 3 months ago (2014-09-04 03:55:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/542463002/1
6 years, 3 months ago (2014-09-04 06:36:36 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1cb05d44a059cf321a805505cd2351dbac293bb7
6 years, 3 months ago (2014-09-04 07:12:16 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:30:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c2e61cc5ee7ece1eb8c876fbc717fd1f7911bce
Cr-Commit-Position: refs/heads/master@{#293280}

Powered by Google App Engine
This is Rietveld 408576698