Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 542413002: Move launcher API to athena/main/public (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move launcher API to athena/main/public BUG=None Committed: https://crrev.com/c986f7cd5ecd85ed3891ec78abfd60b7f8c20e0b Cr-Commit-Position: refs/heads/master@{#293633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -51 lines) Patch
D athena/main/athena_launcher.h View 1 chunk +0 lines, -39 lines 0 comments Download
M athena/main/athena_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_main.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
A + athena/main/public/athena_launcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M athena/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/test/athena_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/athena/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
oshima
6 years, 3 months ago (2014-09-06 06:56:47 UTC) #2
Jun Mukai
lgtm
6 years, 3 months ago (2014-09-06 07:42:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/542413002/1
6 years, 3 months ago (2014-09-06 16:20:07 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 18:20:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/542413002/1
6 years, 3 months ago (2014-09-06 20:01:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8472fe45f344188f9d4030108d6a4f499eeae59e
6 years, 3 months ago (2014-09-06 20:11:59 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:18 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c986f7cd5ecd85ed3891ec78abfd60b7f8c20e0b
Cr-Commit-Position: refs/heads/master@{#293633}

Powered by Google App Engine
This is Rietveld 408576698