Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Unified Diff: runtime/bin/vmservice/observatory/tests/ui/inspector.dart

Issue 542363003: Don't double-escape in strings in the VM Service, and don't use \u0000 to determine the string lengt (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/observatory/test/string_escaping_test.dart ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/observatory/tests/ui/inspector.dart
diff --git a/runtime/bin/vmservice/observatory/tests/ui/inspector.dart b/runtime/bin/vmservice/observatory/tests/ui/inspector.dart
index eb5d458592f288cb398912af9ab8f835a123c193..686d4d6169ce8c30045d5e4b5a84e2041a2d5b77 100644
--- a/runtime/bin/vmservice/observatory/tests/ui/inspector.dart
+++ b/runtime/bin/vmservice/observatory/tests/ui/inspector.dart
@@ -43,8 +43,13 @@ var regex;
var smi;
var stacktrace;
var string;
+var stringEscapedUnicodeEscape;
+var stringHebrew;
var stringLatin1;
+var stringNewLinesAndTabs;
+var stringNullInTheMiddle;
var stringSnowflake;
+var stringTrebleClefs;
var stringUnicode;
var theFalse;
var theNull;
@@ -127,8 +132,13 @@ main() {
smi = 7;
stacktrace = genStacktrace();
string = "Hello";
+ stringEscapedUnicodeEscape = "Should not be A: \\u0041";
+ stringHebrew = "שלום רב שובך צפורה נחמדת"; // Right-to-left text.
stringLatin1 = "blåbærgrød";
+ stringNewLinesAndTabs = "One fish\ttwo fish\nRed fish\tBlue fish\n";
+ stringNullInTheMiddle = "There are four\u0000 words.";
stringSnowflake = "❄";
+ stringTrebleClefs = "1𝄞2𝄞𝄞3𝄞𝄞𝄞"; // Surrogate pair.
stringUnicode = "Îñţérñåţîöñåļîžåţîờñ";
theFalse = false;
theNull = null;
« no previous file with comments | « runtime/bin/vmservice/observatory/test/string_escaping_test.dart ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698