Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html

Issue 542363003: Don't double-escape in strings in the VM Service, and don't use \u0000 to determine the string lengt (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html
diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html b/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html
index 1c8747e12d6f0dcc208f6a95d38c39345538880b..ab7bb160b53bed5b80bcd440e869a61d1bf6d404 100644
--- a/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html
+++ b/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html
@@ -22,11 +22,16 @@
<div title="{{ hoverText }}">{{ ref.valueAsString }}</div>
</template>
- <template if="{{ ref.isString || ref.isBool || ref.isInt ||
+ <template if="{{ ref.isBool || ref.isInt ||
ref.isDouble || ref.isNull }}">
<a on-click="{{ goto }}" _href="{{ url }}">{{ ref.valueAsString }}</a>
</template>
+ <template if="{{ ref.isString }}">
+ <a on-click="{{ goto }}" _href="{{ url }}">{{ asStringLiteral(ref.valueAsString, ref.valueAsStringIsTruncated) }}</a>
+ </template>
+
+
<template if="{{ ref.isAbstractType }}">
<a on-click="{{ goto }}" _href="{{ url }}">{{ ref.name }}</a>
</template>

Powered by Google App Engine
This is Rietveld 408576698