Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: runtime/bin/vmservice/observatory/deployed/web/index_devtools.html

Issue 542363003: Don't double-escape in strings in the VM Service, and don't use \u0000 to determine the string lengt (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/deployed/web/index_devtools.html
diff --git a/runtime/bin/vmservice/observatory/deployed/web/index_devtools.html b/runtime/bin/vmservice/observatory/deployed/web/index_devtools.html
index 06ea44e61003e5cbb182b660a11df58d1ab62acd..afb894c4bec91b72d559263c13bc873dfe8c5b74 100644
--- a/runtime/bin/vmservice/observatory/deployed/web/index_devtools.html
+++ b/runtime/bin/vmservice/observatory/deployed/web/index_devtools.html
@@ -925,11 +925,16 @@ hr {
<div title="{{ hoverText }}">{{ ref.valueAsString }}</div>
</template>
- <template if="{{ ref.isString || ref.isBool || ref.isInt ||
+ <template if="{{ ref.isBool || ref.isInt ||
ref.isDouble || ref.isNull }}">
<a on-click="{{ goto }}" _href="{{ url }}">{{ ref.valueAsString }}</a>
</template>
+ <template if="{{ ref.isString }}">
+ <a on-click="{{ goto }}" _href="{{ url }}">{{ asStringLiteral(ref.valueAsString, ref.valueAsStringIsTruncated) }}</a>
+ </template>
+
+
<template if="{{ ref.isAbstractType }}">
<a on-click="{{ goto }}" _href="{{ url }}">{{ ref.name }}</a>
</template>
@@ -15497,6 +15502,13 @@ hr {
</div>
</template>
+ <template if="{{ instance.isString }}">
+ <div class="memberItem">
+ <div class="memberName">valueAsLiteral</div>
+ <div class="memberValue"> {{ asStringLiteral(instance.valueAsString, instance.valueAsStringIsTruncated) }}</div>
+ </div>
+ </template>
+
<template if="{{ instance.isMirrorReference }}">
<div class="memberItem">
<div class="memberName">referent</div>

Powered by Google App Engine
This is Rietveld 408576698