Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: runtime/vm/service_test.cc

Issue 542363003: Don't double-escape in strings in the VM Service, and don't use \u0000 to determine the string lengt (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« runtime/vm/report_test.cc ('K') | « runtime/vm/report_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 6
7 #include "include/dart_debugger_api.h" 7 #include "include/dart_debugger_api.h"
8 #include "vm/dart_api_impl.h" 8 #include "vm/dart_api_impl.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/debugger.h" 10 #include "vm/debugger.h"
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 handler.filterMsg("id"); 613 handler.filterMsg("id");
614 EXPECT_STREQ( 614 EXPECT_STREQ(
615 "{\"type\":\"Array\"," 615 "{\"type\":\"Array\","
616 "\"class\":{\"type\":\"@Class\",\"name\":\"_List\",}," 616 "\"class\":{\"type\":\"@Class\",\"name\":\"_List\",},"
617 "\"fields\":[]," 617 "\"fields\":[],"
618 "\"length\":1," 618 "\"length\":1,"
619 "\"elements\":[{" 619 "\"elements\":[{"
620 "\"index\":0," 620 "\"index\":0,"
621 "\"value\":{\"type\":\"@String\"," 621 "\"value\":{\"type\":\"@String\","
622 "\"class\":{\"type\":\"@Class\",\"name\":\"_OneByteString\",}," 622 "\"class\":{\"type\":\"@Class\",\"name\":\"_OneByteString\",},"
623 "\"valueAsString\":\"\\\"value\\\"\"}}]}", 623 "\"valueAsString\":\"value\","
624 "\"valueAsStringIsTruncated\":false}}]}",
624 handler.msg()); 625 handler.msg());
625 626
626 // object id ring / invalid => expired 627 // object id ring / invalid => expired
627 service_msg = Eval(lib, "[0, port, ['objects', '99999999'], [], []]"); 628 service_msg = Eval(lib, "[0, port, ['objects', '99999999'], [], []]");
628 Service::HandleIsolateMessage(isolate, service_msg); 629 Service::HandleIsolateMessage(isolate, service_msg);
629 handler.HandleNextMessage(); 630 handler.HandleNextMessage();
630 handler.filterMsg("vmName"); 631 handler.filterMsg("vmName");
631 EXPECT_STREQ( 632 EXPECT_STREQ(
632 "{\"type\":\"Sentinel\",\"id\":\"objects\\/expired\"," 633 "{\"type\":\"Sentinel\",\"id\":\"objects\\/expired\","
633 "\"valueAsString\":\"<expired>\"}", 634 "\"valueAsString\":\"<expired>\"}",
(...skipping 1391 matching lines...) Expand 10 before | Expand all | Expand 10 after
2025 service_msg = Eval(lib, "[0, port, ['profile'], ['tags'], ['hidden']]"); 2026 service_msg = Eval(lib, "[0, port, ['profile'], ['tags'], ['hidden']]");
2026 Service::HandleIsolateMessage(isolate, service_msg); 2027 Service::HandleIsolateMessage(isolate, service_msg);
2027 handler.HandleNextMessage(); 2028 handler.HandleNextMessage();
2028 // Expect error. 2029 // Expect error.
2029 EXPECT_SUBSTRING("\"type\":\"Error\"", handler.msg()); 2030 EXPECT_SUBSTRING("\"type\":\"Error\"", handler.msg());
2030 } 2031 }
2031 2032
2032 #endif // !defined(TARGET_ARCH_ARM64) 2033 #endif // !defined(TARGET_ARCH_ARM64)
2033 2034
2034 } // namespace dart 2035 } // namespace dart
OLDNEW
« runtime/vm/report_test.cc ('K') | « runtime/vm/report_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698