Don't double-escape in strings in the VM Service, and don't use \u0000 to determine the string lengt

runtime/vm/report_test.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/report.h"
 #include "vm/unit_test.h"
 
 namespace dart {
 
@@ skipping 18 matching lines @@
                        js.ToCString());
       // Skip time.
       EXPECT_SUBSTRING("\"message\":{\"type\":\"JSCompatibilityWarning\","
                        "\"script\":{\"type\":\"@Script\",\"id\":"
                        "\"libraries\\/-1\\/scripts\\/Plug\","
                        "\"name\":\"Plug\","
                        "\"kind\":\"script\"},\"tokenPos\":0,"
                        "\"message\":{\"type\":\"@String\"",
                        js.ToCString());
       // Skip private _OneByteString.
-      EXPECT_SUBSTRING("\"valueAsString\":\"\\\"High Voltage\\\"\"}}",
+      EXPECT_SUBSTRING("\"valueAsString\":\"High Voltage\"",

[turnidge, 2014/09/09 16:12:31]

Much nicer.

                        js.ToCString());
     }
   }
   {
     const intptr_t token_pos = 1;
     const char* message = "Low Voltage";
     Report::MessageF(Report::kJSWarning, script, token_pos, "%s", message);
   }
   EXPECT_EQ(2, trace_buffer->Length());
   EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
                    "\"@Script\",\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
                    "\"name\":\"Plug\","
                    "\"kind\":\"script\"},\"tokenPos\":0,"
                    "\"message\":{\"type\":\"@String\"",
                    trace_buffer->At(0)->message);
   // Skip private _OneByteString.
-  EXPECT_SUBSTRING("\"valueAsString\":\"\\\"High Voltage\\\"\"}}",
+  EXPECT_SUBSTRING("\"valueAsString\":\"High Voltage\"",
                    trace_buffer->At(0)->message);
 
   EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
                    "\"@Script\",\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
                    "\"name\":\"Plug\","
                    "\"kind\":\"script\"},\"tokenPos\":1,"
                    "\"message\":{\"type\":\"@String\"",
                    trace_buffer->At(1)->message);
   // Skip private _OneByteString.
-  EXPECT_SUBSTRING("\"valueAsString\":\"\\\"Low Voltage\\\"\"}}",
+  EXPECT_SUBSTRING("\"valueAsString\":\"Low Voltage\"",
                    trace_buffer->At(1)->message);
 
   delete trace_buffer;
 }
 
 }  // namespace dart