Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js

Issue 542363002: Add search hint bubbles to Print Preview advanced options controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js
diff --git a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js
index ff83c6bcdcd0c0ef051a7b9a53d5cce3bd74153c..0e3a5cf5bec7a89d2e8a502c35d63c88d20199c2 100644
--- a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js
+++ b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js
@@ -109,6 +109,10 @@ cr.define('print_preview', function() {
this.renderCapability_();
},
+ get searchBubbleShown() {
+ return getIsVisible(this.getElement()) && !!this.searchBubble_;
+ },
+
/**
* @return {HTMLSelectElement} Select element.
* @private
@@ -155,7 +159,7 @@ cr.define('print_preview', function() {
var textContent = this.capability_.display_name;
var nameMatches = this.query_ ? !!textContent.match(this.query_) : true;
var optionMatches = null;
- if (false && this.query_) {
+ if (this.query_) {
if (this.capability_.type == 'SELECT') {
this.capability_.select_cap.option.some(function(option) {
optionMatches = (option.display_name || '').match(this.query_);
@@ -186,7 +190,6 @@ cr.define('print_preview', function() {
nameEl.title = textContent;
if (optionMatches) {
- window.console.log(optionMatches[0]);
var element =
this.capability_.type == 'SELECT' ? this.select_ : this.text_;
if (!this.searchBubble_) {
« no previous file with comments | « chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698