Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7245)

Unified Diff: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

Issue 542363002: Add search hint bubbles to Print Preview advanced options controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js
index 5ab9d87c58101e259bf54c116507fe62168eb922..f1de16fd8b13e0e40405f794d917a62f0fb1a9b0 100644
--- a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js
+++ b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js
@@ -126,9 +126,15 @@ cr.define('print_preview', function() {
* @private
*/
filterLists_: function(query) {
+ var lastVisibleItemWithBubble = null;
this.items_.forEach(function(item) {
item.updateSearchQuery(query);
+ if (item.searchBubbleShown)
+ lastVisibleItemWithBubble = item;
});
+ setIsVisible(
+ this.getChildElement('.advanced-settings-item-extra-padding'),
+ !!lastVisibleItemWithBubble);
},
/**
@@ -158,14 +164,20 @@ cr.define('print_preview', function() {
var availableHeight = this.getAvailableContentHeight_();
var containerEl = this.getChildElement('.settings-area');
containerEl.style.maxHeight = availableHeight + 'px';
+ var settingsEl = this.getChildElement('.settings');
vendorCapabilities.forEach(function(capability) {
var item = new print_preview.AdvancedSettingsItem(
this.eventTarget_, this.printTicketStore_, capability);
this.addChild(item);
- item.render(this.getChildElement('.settings'));
+ item.render(settingsEl);
this.items_.push(item);
}.bind(this));
+
+ var extraPadding = document.createElement('div');
+ extraPadding.classList.add('advanced-settings-item-extra-padding');
+ extraPadding.hidden = true;
+ settingsEl.appendChild(extraPadding);
},
/**

Powered by Google App Engine
This is Rietveld 408576698