Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome/browser/resources/print_preview/common/search_box.js

Issue 542363002: Add search hint bubbles to Print Preview advanced options controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/common/search_box.js
diff --git a/chrome/browser/resources/print_preview/common/search_box.js b/chrome/browser/resources/print_preview/common/search_box.js
index 4291dbf9482d3e1fb4cba6609577a78ce32927f7..d7c1abc4722c707116040afb455d143c4b02ad7f 100644
--- a/chrome/browser/resources/print_preview/common/search_box.js
+++ b/chrome/browser/resources/print_preview/common/search_box.js
@@ -99,9 +99,13 @@ cr.define('print_preview', function() {
var searchEvent = new Event(SearchBox.EventType.SEARCH);
var query = this.getQuery_();
searchEvent.query = query;
- // Generate regexp-safe query by escaping metacharacters.
- var safeQuery = query.replace(/[-[\]{}()*+?.,\\^$|#\s]/g, '\\$&');
- searchEvent.queryRegExp = new RegExp('(' + safeQuery + ')', 'ig');
+ if (query) {
+ // Generate regexp-safe query by escaping metacharacters.
+ var safeQuery = query.replace(/[-[\]{}()*+?.,\\^$|#\s]/g, '\\$&');
+ searchEvent.queryRegExp = new RegExp('(' + safeQuery + ')', 'ig');
+ } else {
+ searchEvent.queryRegExp = null;
+ }
this.dispatchEvent(searchEvent);
},
« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698