Shortcut a couple of IPCs when the task manager is disabled.

Shortcut a couple of IPCs when the task manager is disabled.

This saves about 6 idle wakeups on the top_10 idle energy benchmark. It can save up to 1/second in the general case.

BUG=411488
Committed: https://crrev.com/d2ba7bcc92922a0d1b5c4dc205c42e0110ecf83f
Cr-Commit-Position: refs/heads/master@{#293813}

[tonyg, 2014-09-06 00:16:54]

tonyg@chromium.org changed reviewers:
+ thakis@chomium.org

[tonyg, 2014-09-06 00:17:44]

tonyg@chromium.org changed reviewers:
+ thestig@chromium.org
- thakis@chomium.org

[tonyg, 2014-09-06 00:18:03]

Lei, since nick is on leave, would you mind taking a look?

[Lei Zhang, 2014-09-06 06:17:47]

lgtm

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
File chrome/browser/task_manager/task_manager.cc (right):

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager.cc:1256: if (!is_updating_byte_count_)
{
nit: no need for braces

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager.cc:1408: void
TaskManagerModel::StartUpdatingByteCount() {
maybe combine into SetUpdatingByteCount(bool is_updating) ? *shrug*

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
File chrome/browser/task_manager/task_manager.h (right):

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager.h:541: bool is_updating_byte_count_;
nit: Mention this is only accessed on the IO thread.

[tonyg, 2014-09-08 18:59:38]

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
File chrome/browser/task_manager/task_manager.cc (right):

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager.cc:1256: if (!is_updating_byte_count_)
{
On 2014/09/06 06:17:46, Lei Zhang wrote:
> nit: no need for braces

Done.

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager.cc:1408: void
TaskManagerModel::StartUpdatingByteCount() {
On 2014/09/06 06:17:47, Lei Zhang wrote:
> maybe combine into SetUpdatingByteCount(bool is_updating) ? *shrug*

Done.

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
File chrome/browser/task_manager/task_manager.h (right):

https://codereview.chromium.org/542353002/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager.h:541: bool is_updating_byte_count_;
On 2014/09/06 06:17:47, Lei Zhang wrote:
> nit: Mention this is only accessed on the IO thread.

Done.

[Lei Zhang, 2014-09-08 19:01:02]

lgtm++

[tonyg, 2014-09-08 19:04:21]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-09-08 19:08:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tonyg@chromium.org/542353002/40001

[commit-bot: I haz the power, 2014-09-08 23:39:39]

Committed patchset #3 (id:40001) as 4aa342f00cf8b4537091c98e275e6a3ee598ae67

[commit-bot: I haz the power, 2014-09-10 03:49:00]

Patchset 3 (id:??) landed as
https://crrev.com/d2ba7bcc92922a0d1b5c4dc205c42e0110ecf83f
Cr-Commit-Position: refs/heads/master@{#293813}