Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

Issue 542333002: Add feedback for 'Inline Local' refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
diff --git a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
index db9cd9e2da494906a90777e06d1e46b9ed7805fc..65e0f0b0167eca6ecd025dbe295ea20ec3489b13 100644
--- a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
+++ b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
@@ -49,6 +49,7 @@ import com.google.dart.server.generated.types.ExtractMethodOptions;
import com.google.dart.server.generated.types.HighlightRegion;
import com.google.dart.server.generated.types.HighlightRegionType;
import com.google.dart.server.generated.types.HoverInformation;
+import com.google.dart.server.generated.types.InlineLocalVariableFeedback;
import com.google.dart.server.generated.types.InlineMethodOptions;
import com.google.dart.server.generated.types.Location;
import com.google.dart.server.generated.types.NavigationRegion;
@@ -1767,6 +1768,50 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {
assertThat(feedback.getLengths()).hasSize(4).contains(6, 7, 8, 9);
}
+ public void test_edit_getRefactoring_response_feedback_inlineLocalVariable() throws Exception {
+ final RefactoringFeedback[] feedbackArray = {null};
+ RefactoringOptions options = null;
+ server.edit_getRefactoring(
+ RefactoringKind.INLINE_LOCAL_VARIABLE,
+ "file1.dart",
+ 1,
+ 2,
+ false,
+ options,
+ new GetRefactoringConsumer() {
+ @Override
+ public void computedRefactorings(List<RefactoringProblem> problems,
+ RefactoringFeedback feedback, SourceChange change, List<String> potentialEdits) {
+ feedbackArray[0] = feedback;
+ }
+ });
+
+ putResponse(//
+ "{",
+ " 'id': '0',",
+ " 'result': {",
+ " 'problems': [",
+ " {",
+ " 'severity': 'INFO',",
+ " 'message': 'message1'",
+ " }",
+ " ],",
+ " 'feedback': {",
+ " 'name': myVar,",
+ " 'occurrences': 3",
+ " },",
+ " 'change': " + getSourceChangeJson() + ",",
+ " 'potentialEdits': ['one']",
+ " }",
+ "}");
+ server.test_waitForWorkerComplete();
+
+ // assertions on 'feedback'
+ InlineLocalVariableFeedback feedback = (InlineLocalVariableFeedback) feedbackArray[0];
+ assertEquals("myVar", feedback.getName());
+ assertEquals(3, feedback.getOccurrences());
+ }
+
public void test_edit_getRefactoring_response_feedback_rename() throws Exception {
final Object[] feedbackArray = {null};
RefactoringOptions options = null;
@@ -2276,7 +2321,7 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {
" 'event': 'server.status',",
" 'params': {",
" 'analysis': {",
- " 'analyzing': false",
+ " 'isAnalyzing': false",
" }",
" }",
"}");
@@ -2291,7 +2336,7 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {
" 'event': 'server.status',",
" 'params': {",
" 'analysis': {",
- " 'analyzing': true,",
+ " 'isAnalyzing': true,",
" 'analysisTarget': 'target0'",
" }",
" }",

Powered by Google App Engine
This is Rietveld 408576698