Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: ui/views/view_targeter.cc

Issue 542323002: Convert ui::GestureEvent coordinates during targeting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/events/event_targeter.h ('k') | ui/views/view_targeter_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/view_targeter.h" 5 #include "ui/views/view_targeter.h"
6 6
7 #include "ui/events/event_target.h" 7 #include "ui/events/event_target.h"
8 #include "ui/views/focus/focus_manager.h" 8 #include "ui/views/focus/focus_manager.h"
9 #include "ui/views/view.h" 9 #include "ui/views/view.h"
10 #include "ui/views/view_targeter_delegate.h" 10 #include "ui/views/view_targeter_delegate.h"
(...skipping 21 matching lines...) Expand all
32 View* view = static_cast<View*>(root); 32 View* view = static_cast<View*>(root);
33 33
34 if (event->IsKeyEvent()) 34 if (event->IsKeyEvent())
35 return FindTargetForKeyEvent(view, *static_cast<ui::KeyEvent*>(event)); 35 return FindTargetForKeyEvent(view, *static_cast<ui::KeyEvent*>(event));
36 36
37 if (event->IsScrollEvent()) { 37 if (event->IsScrollEvent()) {
38 return FindTargetForScrollEvent(view, 38 return FindTargetForScrollEvent(view,
39 *static_cast<ui::ScrollEvent*>(event)); 39 *static_cast<ui::ScrollEvent*>(event));
40 } 40 }
41 41
42 if (event->IsGestureEvent()) 42 if (event->IsGestureEvent()) {
43 return FindTargetForGestureEvent(view, *(event->AsGestureEvent())); 43 ui::GestureEvent* gesture = event->AsGestureEvent();
44 View* gesture_target = FindTargetForGestureEvent(view, *gesture);
45 root->ConvertEventToTarget(gesture_target, gesture);
46 return gesture_target;
47 }
44 48
45 NOTREACHED() << "ViewTargeter does not yet support this event type."; 49 NOTREACHED() << "ViewTargeter does not yet support this event type.";
46 return NULL; 50 return NULL;
47 } 51 }
48 52
49 ui::EventTarget* ViewTargeter::FindNextBestTarget( 53 ui::EventTarget* ViewTargeter::FindNextBestTarget(
50 ui::EventTarget* previous_target, 54 ui::EventTarget* previous_target,
51 ui::Event* event) { 55 ui::Event* event) {
52 if (!previous_target) 56 if (!previous_target)
53 return NULL; 57 return NULL;
54 58
55 if (event->IsGestureEvent()) { 59 if (event->IsGestureEvent()) {
56 return FindNextBestTargetForGestureEvent(previous_target, 60 ui::GestureEvent* gesture = event->AsGestureEvent();
57 *(event->AsGestureEvent())); 61 ui::EventTarget* next_target =
62 FindNextBestTargetForGestureEvent(previous_target, *gesture);
63 previous_target->ConvertEventToTarget(next_target, gesture);
64 return next_target;
58 } 65 }
59 66
60 return previous_target->GetParentTarget(); 67 return previous_target->GetParentTarget();
61 } 68 }
62 69
63 bool ViewTargeter::SubtreeCanAcceptEvent( 70 bool ViewTargeter::SubtreeCanAcceptEvent(
64 ui::EventTarget* target, 71 ui::EventTarget* target,
65 const ui::LocatedEvent& event) const { 72 const ui::LocatedEvent& event) const {
66 NOTREACHED(); 73 NOTREACHED();
67 return false; 74 return false;
(...skipping 30 matching lines...) Expand all
98 } 105 }
99 106
100 ui::EventTarget* ViewTargeter::FindNextBestTargetForGestureEvent( 107 ui::EventTarget* ViewTargeter::FindNextBestTargetForGestureEvent(
101 ui::EventTarget* previous_target, 108 ui::EventTarget* previous_target,
102 const ui::GestureEvent& gesture) { 109 const ui::GestureEvent& gesture) {
103 NOTREACHED(); 110 NOTREACHED();
104 return NULL; 111 return NULL;
105 } 112 }
106 113
107 } // namespace views 114 } // namespace views
OLDNEW
« no previous file with comments | « ui/events/event_targeter.h ('k') | ui/views/view_targeter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698