Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 542283003: Relax inspector_websocket.DispatchNotificationsUntilDone timeout condition (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 3 months ago
Reviewers:
nduca, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Modify inspector_websocket.DispatchNotificationsUntilDone to only timeout since the last byte received. This patch also clean up the MockTimer API a little bit by making sure that the module's time package is replaced when mock timer is gc'ed. BUG=400859 Committed: https://crrev.com/5fce5ef7bf7739c3751122e98f9c23f9bb2ad1a4 Cr-Commit-Position: refs/heads/master@{#295052}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove unnecessary print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -19 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py View 3 chunks +17 lines, -7 lines 0 comments Download
A tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py View 1 chunk +102 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/unittest/gtest_progress_reporter_unittest.py View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/unittest/simple_mock.py View 2 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
nednguyen
6 years, 3 months ago (2014-09-16 05:00:29 UTC) #2
nednguyen
On 2014/09/16 05:00:29, nednguyen wrote: PTAL since this a P1 bug.
6 years, 3 months ago (2014-09-16 05:00:44 UTC) #3
nduca
lgtm
6 years, 3 months ago (2014-09-16 05:06:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/542283003/20001
6 years, 3 months ago (2014-09-16 05:07:48 UTC) #7
chrishenry
lgtm lgtm, but see comment. https://codereview.chromium.org/542283003/diff/20001/tools/telemetry/telemetry/results/gtest_progress_reporter.py File tools/telemetry/telemetry/results/gtest_progress_reporter.py (right): https://codereview.chromium.org/542283003/diff/20001/tools/telemetry/telemetry/results/gtest_progress_reporter.py#newcode52 tools/telemetry/telemetry/results/gtest_progress_reporter.py:52: print time Is this ...
6 years, 3 months ago (2014-09-16 05:16:52 UTC) #8
nednguyen
https://codereview.chromium.org/542283003/diff/20001/tools/telemetry/telemetry/results/gtest_progress_reporter.py File tools/telemetry/telemetry/results/gtest_progress_reporter.py (right): https://codereview.chromium.org/542283003/diff/20001/tools/telemetry/telemetry/results/gtest_progress_reporter.py#newcode52 tools/telemetry/telemetry/results/gtest_progress_reporter.py:52: print time On 2014/09/16 05:16:51, chrishenry wrote: > Is ...
6 years, 3 months ago (2014-09-16 05:27:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/542283003/40001
6 years, 3 months ago (2014-09-16 05:31:02 UTC) #12
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-16 07:31:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/542283003/40001
6 years, 3 months ago (2014-09-16 12:54:16 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 69ee848bdd525bcaf3fb70c65ce79f4a0b92386a
6 years, 3 months ago (2014-09-16 13:29:24 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 13:30:35 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fce5ef7bf7739c3751122e98f9c23f9bb2ad1a4
Cr-Commit-Position: refs/heads/master@{#295052}

Powered by Google App Engine
This is Rietveld 408576698