chrome/browser/ui/content_settings/content_setting_bubble_model.cc - Issue 542253003: Add a global on/off switch for content settings and expose a toggle on the Website Settings options…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

Issue 542253003: Add a global on/off switch for content settings and expose a toggle on the Website Settings options… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@global-settings

Patch Set: Forgot to clarify ownership comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/content_settings_override_provider.cc ('K') | « chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc ('k') | chrome/browser/ui/website_settings/website_settings.cc » ('j') | chrome/browser/ui/website_settings/website_settings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

index d0bc409d87e0cf480aa18b028e44611051f1911e..78bee3049633e13a6b4e3a23a2321af8e8ff841f 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

@@ -356,8 +356,8 @@ void ContentSettingSingleRadioGroup::SetRadioGroup() {

} else {

SettingInfo info;

HostContentSettingsMap* map = profile()->GetHostContentSettingsMap();

- scoped_ptr<base::Value> value(map->GetWebsiteSetting(

- url, url, content_type(), std::string(), &info));

+ scoped_ptr<base::Value> value =

+ map->GetWebsiteSetting(url, url, content_type(), std::string(), &info);

setting = content_settings::ValueToContentSetting(value.get());

setting_source = info.source;

setting_is_wildcard =