[SyncFS] Make on-disk version default for metadata database index

[SyncFS] Make on-disk version default for metadata database index

BUG=347425
TEST=unit_tests --gtest_filter="MetadataDatabase*"

Committed: https://crrev.com/bca076afd56bda64577e6a708da21e4c2ebf2a18
Cr-Commit-Position: refs/heads/master@{#293714}

[peria, 2014-09-08 06:16:57]

Patchset #1 (id:1) has been deleted

[peria, 2014-09-08 06:19:32]

peria@chromium.org changed reviewers:
+ nhiroki@chromium.org, tzik@chromium.org

[peria, 2014-09-08 06:19:33]

PTL.

[nhiroki, 2014-09-08 06:42:55]

lgtm

[peria, 2014-09-08 06:51:26]

Thanks for your reviews, but please suspend reviewing it for a while.

[peria, 2014-09-08 07:49:42]

Fixed.
PTAL.

[tzik, 2014-09-08 07:53:56]

lgtm

[nhiroki, 2014-09-08 10:45:10]

lgtm2

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1428: 
nit: there is an extra line

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
(right):

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:511:
}
To make sure that the size of |index1| is the same with the size of |index2|,
can you add following checks here?

EXPECT_TRUE(!itr1->Valid());
EXPECT_TRUE(!itr2->Valid());

(Or do we have another way to get the size of the index?)

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:519:
true,  // enable_on_disk_index
How about passing |metadata_database_.enable_on_disk_index_| instead of |true|?

[peria, 2014-09-08 10:53:05]

Now 'lgtm' is accepted iff it is a word (no other characters are appended).

Thanks, submitting.

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1428: 
On 2014/09/08 10:45:10, nhiroki wrote:
> nit: there is an extra line

Done.

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
(right):

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:511:
}
On 2014/09/08 10:45:10, nhiroki wrote:
> To make sure that the size of |index1| is the same with the size of |index2|,
> can you add following checks here?
> 
> EXPECT_TRUE(!itr1->Valid());
> EXPECT_TRUE(!itr2->Valid());
> 
> (Or do we have another way to get the size of the index?)

Done.

https://codereview.chromium.org/542233003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:519:
true,  // enable_on_disk_index
On 2014/09/08 10:45:10, nhiroki wrote:
> How about passing |metadata_database_.enable_on_disk_index_| instead of
|true|?

Done.

[peria, 2014-09-08 10:53:09]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-09-08 10:54:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/542233003/60001

[peria, 2014-09-08 11:17:16]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-09-08 11:18:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/542233003/80001

[commit-bot: I haz the power, 2014-09-08 13:21:51]

Committed patchset #4 (id:80001) as e09d2b33530fc957e5caf8d425b0d3c9dea23107

[commit-bot: I haz the power, 2014-09-10 03:45:55]

Patchset 4 (id:??) landed as
https://crrev.com/bca076afd56bda64577e6a708da21e4c2ebf2a18
Cr-Commit-Position: refs/heads/master@{#293714}