Use a different plist key for iOS versioning

Use a different plist key for iOS versioning

App Store rules appear to be moving toward enforcing the format of
CFBundleVerison on iOS, so this allows setting a custom plist key to
store the full Chrome version instead.

BUG=411302
Committed: https://crrev.com/5e617acfcbe4287342fbd7351039b443fec9d6ee
Cr-Commit-Position: refs/heads/master@{#293802}

[stuartmorgan, 2014-09-05 16:46:00]

stuartmorgan@chromium.org changed reviewers:
+ mark@chromium.org

[stuartmorgan, 2014-09-05 16:46:00]

The iOS tweak_info_plist is still not upstreamed, which is why there are no
other changes in this CL, but the idea is that we'll put the three-part version
we already have for CFShortBundleVersion (Chrome version without the .0) in
CFBundleVersion, and put the real version in this new key.

[rohitrao (ping after 24h), 2014-09-05 17:01:49]

rohitrao@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2014-09-05 17:01:50]

lgtm

https://codereview.chromium.org/542223002/diff/1/base/file_version_info_mac.mm
File base/file_version_info_mac.mm (right):

https://codereview.chromium.org/542223002/diff/1/base/file_version_info_mac.m...
base/file_version_info_mac.mm:69: base::string16
version(GetString16Value(CFSTR("CrBundleVersion")));
We can use whatever key we want without worrying about conflicts?

https://codereview.chromium.org/542223002/diff/1/base/file_version_info_mac.m...
base/file_version_info_mac.mm:72: return
GetString16Value(CFSTR("CFBundleVersion"));
Do you intend to remove the fallback code eventually, and make CrBundleVersion
mandatory?

[stuartmorgan, 2014-09-05 17:15:09]

https://codereview.chromium.org/542223002/diff/1/base/file_version_info_mac.mm
File base/file_version_info_mac.mm (right):

https://codereview.chromium.org/542223002/diff/1/base/file_version_info_mac.m...
base/file_version_info_mac.mm:69: base::string16
version(GetString16Value(CFSTR("CrBundleVersion")));
On 2014/09/05 17:01:50, rohitrao wrote:
> We can use whatever key we want without worrying about conflicts?

I can't imagine Apple would start using Cr as a prefix, and we control
everything else that would go in here.

https://codereview.chromium.org/542223002/diff/1/base/file_version_info_mac.m...
base/file_version_info_mac.mm:72: return
GetString16Value(CFSTR("CFBundleVersion"));
On 2014/09/05 17:01:50, rohitrao wrote:
> Do you intend to remove the fallback code eventually, and make CrBundleVersion
> mandatory?

Since this is in base/ I wasn't planning on it. There's no reason I can think of
that another iOS app using base version info would necessarily have to have a
non-CFBundleVersion-compliant version, so forcing everyone to a different key
seemed unnecessary.

[stuartmorgan, 2014-09-05 17:24:55]

https://codereview.chromium.org/542223002/diff/1/base/file_version_info_mac.mm
File base/file_version_info_mac.mm (right):

https://codereview.chromium.org/542223002/diff/1/base/file_version_info_mac.m...
base/file_version_info_mac.mm:72: return
GetString16Value(CFSTR("CFBundleVersion"));
Also, the fallback should make life easier for test apps.

[Mark Mentovai, 2014-09-05 17:29:12]

LGTM

[stuartmorgan, 2014-09-08 17:44:00]

The CQ bit was checked by stuartmorgan@chromium.org

[commit-bot: I haz the power, 2014-09-08 17:48:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/542223002/1

[commit-bot: I haz the power, 2014-09-08 22:52:34]

Committed patchset #1 (id:1) as 2213a2619d191e6a9c41d4c75aeadf320d06fbf1

[commit-bot: I haz the power, 2014-09-10 03:48:40]

Patchset 1 (id:??) landed as
https://crrev.com/5e617acfcbe4287342fbd7351039b443fec9d6ee
Cr-Commit-Position: refs/heads/master@{#293802}