MacViews: Get OSExchangeDataTest to pass

ui/base/dragdrop/os_exchange_data_provider_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/dragdrop/os_exchange_data_provider_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/logging.h"
 #include "base/pickle.h"
 #include "base/strings/sys_string_conversions.h"
 #import "third_party/mozilla/NSPasteboard+Utils.h"
-#import "ui/base/dragdrop/cocoa_dnd_util.h"
 #include "url/gurl.h"
 
 namespace ui {
 
 OSExchangeDataProviderMac::OSExchangeDataProviderMac()
     : pasteboard_([[NSPasteboard pasteboardWithUniqueName] retain]) {
 }
 
 OSExchangeDataProviderMac::OSExchangeDataProviderMac(NSPasteboard* pasteboard)
     : pasteboard_([pasteboard retain]) {
@@ skipping 14 matching lines @@
   NOTIMPLEMENTED();
   return false;
 }
 
 void OSExchangeDataProviderMac::SetString(const base::string16& string) {
   [pasteboard_ writeObjects:@[ base::SysUTF16ToNSString(string) ]];
 }
 
 void OSExchangeDataProviderMac::SetURL(const GURL& url,
                                        const base::string16& title) {
-  [pasteboard_ setDataForURL:base::SysUTF8ToNSString(url.spec())
-                       title:base::SysUTF16ToNSString(title)];
+  NSURL* ns_url = [NSURL URLWithString:base::SysUTF8ToNSString(url.spec())];
+  [pasteboard_ writeObjects:@[ ns_url ]];
+
+  [pasteboard_ setString:base::SysUTF16ToNSString(title)
+                 forType:kCorePasteboardFlavorType_urln];
 }
 
 void OSExchangeDataProviderMac::SetFilename(const base::FilePath& path) {
-  NOTIMPLEMENTED();
+  [pasteboard_ setPropertyList:@[ base::SysUTF8ToNSString(path.value()) ]
+                       forType:NSFilenamesPboardType];
 }
 
 void OSExchangeDataProviderMac::SetFilenames(
     const std::vector<FileInfo>& filenames) {
   NOTIMPLEMENTED();
 }
 
 void OSExchangeDataProviderMac::SetPickledData(
     const OSExchangeData::CustomFormat& format,
     const Pickle& data) {
   NSData* ns_data = [NSData dataWithBytes:data.data() length:data.size()];
   [pasteboard_ setData:ns_data forType:format.ToNSString()];
 }
 
 bool OSExchangeDataProviderMac::GetString(base::string16* data) const {
   DCHECK(data);
   NSArray* items = [pasteboard_ readObjectsForClasses:@[ [NSString class] ]
                                               options:@{ }];
   if ([items count] == 0)
     return false;
 
   *data = base::SysNSStringToUTF16([items objectAtIndex:0]);
   return true;
 }
 
 bool OSExchangeDataProviderMac::GetURLAndTitle(
     OSExchangeData::FilenameToURLPolicy policy,
     GURL* url,
     base::string16* title) const {
-  return PopulateURLAndTitleFromPasteboard(
-      url, title, pasteboard_, policy == OSExchangeData::CONVERT_FILENAMES);
+  NSArray* items = [pasteboard_ readObjectsForClasses:@[ [NSURL class] ]
+                                              options:@{ }];
+  if ([items count] == 0)
+    return false;
+
+  NSURL* ns_url = [items objectAtIndex:0];
+
+  if (policy == OSExchangeData::DO_NOT_CONVERT_FILENAMES) {
+    // If the URL matches the filename, assume that it came from SetFilename().
+    // Don't return it if we are not supposed to convert filename to URL.
+    NSArray* paths = [pasteboard_ propertyListForType:NSFilenamesPboardType];
+    if ([paths count] > 0 && [[paths objectAtIndex:0] isEqual:[ns_url path]])

[dcheng, 2014/09/15 21:38:47]

Is there some guarantee that the URLs and filenames are populated in 'parallel'
order?

[Andre, 2014/09/16 18:00:08]

Maybe not.
Changed it to use containsObject.

+        return false;
+  }
+
+  if (url) {
+    *url = GURL([[ns_url absoluteString] UTF8String]);
+  }
+  if (title) {
+    *title = base::SysNSStringToUTF16(
+        [pasteboard_ stringForType:kCorePasteboardFlavorType_urln]);
+  }
+  return true;
 }
 
 bool OSExchangeDataProviderMac::GetFilename(base::FilePath* path) const {
-  NOTIMPLEMENTED();
-  return false;
+  NSArray* paths = [pasteboard_ propertyListForType:NSFilenamesPboardType];
+  if ([paths count] == 0)
+    return false;
+
+  *path = base::FilePath([[paths objectAtIndex:0] UTF8String]);
+  return true;
 }
 
 bool OSExchangeDataProviderMac::GetFilenames(
     std::vector<FileInfo>* filenames) const {
   NOTIMPLEMENTED();
   return false;
 }
 
 bool OSExchangeDataProviderMac::GetPickledData(
     const OSExchangeData::CustomFormat& format,
     Pickle* data) const {
   DCHECK(data);
   NSData* ns_data = [pasteboard_ dataForType:format.ToNSString()];
   if (!ns_data)
     return false;
 
   *data = Pickle(static_cast<const char*>([ns_data bytes]), [ns_data length]);
   return true;
 }
 
 bool OSExchangeDataProviderMac::HasString() const {
   NSArray* classes = @[ [NSString class] ];
   return [pasteboard_ canReadObjectForClasses:classes options:nil];
 }
 
 bool OSExchangeDataProviderMac::HasURL(
     OSExchangeData::FilenameToURLPolicy policy) const {
-  GURL url;
-  base::string16 title;
-  return GetURLAndTitle(policy, &url, &title);
+  return GetURLAndTitle(policy, NULL, NULL);
 }
 
 bool OSExchangeDataProviderMac::HasFile() const {
-  NOTIMPLEMENTED();
-  return false;
+  return [[pasteboard_ types] containsObject:NSFilenamesPboardType];
 }
 
 bool OSExchangeDataProviderMac::HasCustomFormat(
     const OSExchangeData::CustomFormat& format) const {
   return [[pasteboard_ types] containsObject:format.ToNSString()];
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // OSExchangeData, public:
 
 // static
 OSExchangeData::Provider* OSExchangeData::CreateProvider() {
   return new OSExchangeDataProviderMac;
 }
 
 }  // namespace ui