MacViews: Get OSExchangeDataTest to pass

ui/base/dragdrop/os_exchange_data_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/pickle.h"
 #include "base/strings/utf_string_conversions.h"
 #include "net/base/filename_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 86 matching lines @@
 TEST_F(OSExchangeDataTest, TestFileToURLConversion) {
   OSExchangeData data;
   EXPECT_FALSE(data.HasURL(OSExchangeData::DO_NOT_CONVERT_FILENAMES));
   EXPECT_FALSE(data.HasURL(OSExchangeData::CONVERT_FILENAMES));
   EXPECT_FALSE(data.HasFile());
 
   base::FilePath current_directory;
   ASSERT_TRUE(base::GetCurrentDirectory(&current_directory));
 
   data.SetFilename(current_directory);
+
+// NSPasteboard does not support not converting, writing NSFilenamesPboardType

[dcheng, 2014/09/10 00:22:54]

We need to manually clear it in the code that reads it. This property is
important to prevent leakage of file paths to normal web content.

[Andre, 2014/09/13 01:10:50]

I couldn't find a way to clear the URL from the pasteboard.
I've implemented a different scheme in patchset #2, PTAL.

+// will automatically populates URL types as well.
+#if !defined(OS_MACOSX)
   {
     EXPECT_FALSE(data.HasURL(OSExchangeData::DO_NOT_CONVERT_FILENAMES));
     GURL actual_url;
     base::string16 actual_title;
     EXPECT_FALSE(data.GetURLAndTitle(
         OSExchangeData::DO_NOT_CONVERT_FILENAMES, &actual_url, &actual_title));
     EXPECT_EQ(GURL(), actual_url);
     EXPECT_EQ(base::string16(), actual_title);
   }
+#endif
+
   {
 // Filename to URL conversion is not implemented on ChromeOS or on non-X11 Linux
 // builds.
 #if defined(OS_CHROMEOS) || (defined(OS_LINUX) && !defined(USE_X11))
     const bool expected_success = false;
     const GURL expected_url;
 #else
     const bool expected_success = true;
     const GURL expected_url(net::FilePathToFileURL(current_directory));
 #endif
     EXPECT_EQ(expected_success, data.HasURL(OSExchangeData::CONVERT_FILENAMES));
     GURL actual_url;
     base::string16 actual_title;
     EXPECT_EQ(
         expected_success,
         data.GetURLAndTitle(
             OSExchangeData::CONVERT_FILENAMES, &actual_url, &actual_title));
-    EXPECT_EQ(expected_url, actual_url);
+    // Some Mac OS versions return the URL in file://localhost form instead
+    // of file:///, so we compare the url's path not its absolute string.
+    EXPECT_EQ(expected_url.path(), actual_url.path());
     EXPECT_EQ(base::string16(), actual_title);
   }
   EXPECT_TRUE(data.HasFile());
   base::FilePath actual_path;
   EXPECT_TRUE(data.GetFilename(&actual_path));
   EXPECT_EQ(current_directory, actual_path);
 }
 
 TEST_F(OSExchangeDataTest, TestPickledData) {
   const OSExchangeData::CustomFormat kTestFormat =
@@ skipping 29 matching lines @@
   data.SetHtml(html, url);
 
   OSExchangeData copy(data.provider().Clone());
   base::string16 read_html;
   EXPECT_TRUE(copy.GetHtml(&read_html, &url));
   EXPECT_EQ(html, read_html);
 }
 #endif
 
 }  // namespace ui