Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 542193003: MIPS: Rename ascii to one-byte where applicable. (Closed)

Created:
6 years, 3 months ago by balazs.kilvady
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Rename ascii to one-byte where applicable. Port r23840 (5463c43) BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -441 lines) Patch
M src/mips/code-stubs-mips.h View 1 chunk +13 lines, -22 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 16 chunks +33 lines, -45 lines 1 comment Download
M src/mips/codegen-mips.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 8 chunks +11 lines, -15 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 3 chunks +29 lines, -41 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 8 chunks +50 lines, -74 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 12 chunks +16 lines, -16 lines 0 comments Download
M src/mips64/code-stubs-mips64.h View 1 chunk +13 lines, -22 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 16 chunks +37 lines, -49 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 8 chunks +11 lines, -15 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 3 chunks +30 lines, -42 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 8 chunks +50 lines, -74 lines 0 comments Download
M src/mips64/regexp-macro-assembler-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/regexp-macro-assembler-mips64.cc View 12 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
balazs.kilvady
6 years, 3 months ago (2014-09-10 18:28:32 UTC) #2
paul.l...
LGTM, I'll land this (and fix the nit.) https://codereview.chromium.org/542193003/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/542193003/diff/1/src/mips/code-stubs-mips.cc#newcode2159 src/mips/code-stubs-mips.cc:2159: __ ...
6 years, 3 months ago (2014-09-10 19:12:57 UTC) #3
paul.l...
6 years, 3 months ago (2014-09-10 19:19:17 UTC) #4 
Committed as r23848.

Powered by Google App Engine
This is Rietveld 408576698