Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1768)

Unified Diff: device/hid/hid_service.h

Issue 542153004: Make the device::HidService destructor protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/hid/hid_connection_unittest.cc ('k') | device/hid/hid_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/hid/hid_service.h
diff --git a/device/hid/hid_service.h b/device/hid/hid_service.h
index cc7813b9b4aeefae70b819bd44028c36574b5d3f..c3702038b4b19f2e57635c006304cd942fa70a92 100644
--- a/device/hid/hid_service.h
+++ b/device/hid/hid_service.h
@@ -23,8 +23,6 @@ class HidService {
static HidService* GetInstance(
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);
- virtual ~HidService();
-
// Enumerates and returns a list of device identifiers.
virtual void GetDevices(std::vector<HidDeviceInfo>* devices);
@@ -41,6 +39,7 @@ class HidService {
typedef std::map<HidDeviceId, HidDeviceInfo> DeviceMap;
HidService();
+ virtual ~HidService();
Ken Rockot(use gerrit already) 2014/09/05 19:52:04 Any reason not to make it private?
Reilly Grant (use Gerrit) 2014/09/05 20:19:05 Sub-classes.
void AddDevice(const HidDeviceInfo& info);
void RemoveDevice(const HidDeviceId& device_id);
@@ -49,6 +48,8 @@ class HidService {
base::ThreadChecker thread_checker_;
private:
+ class Destroyer;
+
DeviceMap devices_;
DISALLOW_COPY_AND_ASSIGN(HidService);
« no previous file with comments | « device/hid/hid_connection_unittest.cc ('k') | device/hid/hid_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698