Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: device/hid/hid_connection_unittest.cc

Issue 542153004: Make the device::HidService destructor protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/hid/hid_service.h » ('j') | device/hid/hid_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/hid/hid_connection_unittest.cc
diff --git a/device/hid/hid_connection_unittest.cc b/device/hid/hid_connection_unittest.cc
index 064720f4c03d9ac2d8a5432bfce483b614d1eafb..5c67edf349e098f3d0947fae31b7a332ae47191f 100644
--- a/device/hid/hid_connection_unittest.cc
+++ b/device/hid/hid_connection_unittest.cc
@@ -73,8 +73,7 @@ class HidConnectionTest : public testing::Test {
if (!UsbTestGadget::IsTestEnabled()) return;
message_loop_.reset(new base::MessageLoopForIO());
- service_.reset(HidService::GetInstance(
- message_loop_->message_loop_proxy()));
+ service_ = HidService::GetInstance(message_loop_->message_loop_proxy());
ASSERT_TRUE(service_);
test_gadget_ = UsbTestGadget::Claim();
@@ -119,7 +118,7 @@ class HidConnectionTest : public testing::Test {
}
scoped_ptr<base::MessageLoopForIO> message_loop_;
- scoped_ptr<HidService> service_;
+ HidService* service_;
scoped_ptr<UsbTestGadget> test_gadget_;
HidDeviceId device_id_;
};
« no previous file with comments | « no previous file | device/hid/hid_service.h » ('j') | device/hid/hid_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698