Issue 542136: Fix (hopefully) the linux64 build issue exposed by Neb's CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542136: Fix (hopefully) the linux64 build issue exposed by Neb's CL. (Closed)

Created:
10 years, 11 months ago by sehr (please use chromium)

Modified:
9 years, 7 months ago

Reviewers:
laforge, neb

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix (hopefully) the linux64 build issue exposed by Neb's CL. TBR=laforge Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36590

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	webkit/tools/pepper_test_plugin/event_handler.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

laforge

10 years, 11 months ago (2010-01-20 01:25:24 UTC) #2

LGTM

On Tue, Jan 19, 2010 at 5:17 PM, <sehr@google.com> wrote:

> Reviewers: laforge, neb,
>
> Description:
> Fix (hopefully) the linux64 build issue exposed by Neb's CL.
> TBR=laforge
>
>
> Please review this at http://codereview.chromium.org/542136
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/pepper_test_plugin/event_handler.cc
>
>
> Index: webkit/tools/pepper_test_plugin/event_handler.cc
> ===================================================================
> --- webkit/tools/pepper_test_plugin/event_handler.cc    (revision 36529)
> +++ webkit/tools/pepper_test_plugin/event_handler.cc    (working copy)
> @@ -55,10 +55,14 @@
>  }
>
>  std::string EventHandler::EventName(double timestamp, int32 type) {
> +#if !defined(OS_LINUX)
>   std::stringstream strstr;
>   strstr.setf(std::ios::fixed, std::ios::floatfield);
>   strstr << timestamp << ": ";
>   std::string str(strstr.str());
> +#else
> +  std::string str;
> +#endif
>   switch (type) {
>     case NPEventType_MouseDown:
>       return str + "MouseDown";
>
>
>

Expand Messages | Collapse Messages