Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 54213002: add some GM tests for rects (Closed)

Created:
7 years, 1 month ago by yunchao
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add some GM tests for rects BUG= Committed: http://code.google.com/p/skia/source/detail?r=12073

Patch Set 1 #

Patch Set 2 : Add rects to GM ignore-test.txt #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M gm/rects.cpp View 3 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yunchao
separate the added GM tests from this CL https://codereview.chromium.org/23712005/ to compare the GM output for ...
7 years, 1 month ago (2013-10-31 07:29:56 UTC) #1
robertphillips
lgtm. Could you add this GM to the list in expectations\gm\ignored-tests.txt before landing?
7 years, 1 month ago (2013-10-31 11:36:47 UTC) #2
bsalomon
On 2013/10/31 11:36:47, robertphillips wrote: > lgtm. Could you add this GM to the list ...
7 years, 1 month ago (2013-10-31 15:38:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/54213002/70001
7 years, 1 month ago (2013-11-01 01:13:30 UTC) #4
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-01 01:13:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/54213002/140001
7 years, 1 month ago (2013-11-01 02:38:09 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 11:54:36 UTC) #7
Message was sent while issue was closed.
Change committed as 12073

Powered by Google App Engine
This is Rietveld 408576698