Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 542113003: bindings: Introduces ScriptWrappable::associateWithWrapper in addition to wrap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 542113003: bindings: Introduces ScriptWrappable::associateWithWrapper in addition to wrap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptWrappable.h ('K') | « Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp ('k') | Source/bindings/tests/results/V8TestNode.cpp » ('j') | Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

index 4f5b8167d063f33bc27b43bb8dc14012178dca24..99a14e40b622e23362b08ce1a3981356757a90b2 100644

--- a/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -97,7 +97,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

}

RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> impl = TestInterfaceWillBeGarbageCollected::create(str);

v8::Handle<v8::Object> wrapper = info.Holder();

- V8DOMWrapper::associateObjectWithWrapper<V8TestInterfaceWillBeGarbageCollected>(impl.release(), &V8TestInterfaceWillBeGarbageCollected::wrapperTypeInfo, wrapper, info.GetIsolate());

+ impl->associateWithWrapper(&V8TestInterfaceWillBeGarbageCollected::wrapperTypeInfo, wrapper, info.GetIsolate());

v8SetReturnValue(info, wrapper);

}

@@ -134,7 +134,7 @@ static void V8TestInterfaceWillBeGarbageCollectedConstructorCallback(const v8::F

}

RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> impl = TestInterfaceWillBeGarbageCollected::createForJSConstructor(str);

v8::Handle<v8::Object> wrapper = info.Holder();

- V8DOMWrapper::associateObjectWithWrapper<V8TestInterfaceWillBeGarbageCollected>(impl.release(), &V8TestInterfaceWillBeGarbageCollectedConstructor::wrapperTypeInfo, wrapper, info.GetIsolate());

+ impl->associateWithWrapper(&V8TestInterfaceWillBeGarbageCollectedConstructor::wrapperTypeInfo, wrapper, info.GetIsolate());

v8SetReturnValue(info, wrapper);

}