bindings: Introduces ScriptWrappable::associateWithWrapper in addition to wrap.

Source/core/dom/Document.cpp

Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index ac3d14065363a169bfbaab9e2a1207145b4f692b..630733b12b641c8ddf93a58aab979ada6560953f 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -5776,13 +5776,16 @@ v8::Handle<v8::Object> Document::wrap(v8::Handle<v8::Object> creationContext, v8
         return wrapper;
 
     wrapperType->installConditionallyEnabledProperties(wrapper, isolate);
+    return associateWithWrapper(wrapperType, wrapper, isolate);
+}
+
+v8::Handle<v8::Object> Document::associateWithWrapper(const WrapperTypeInfo* wrapperType, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate)
+{
     wrapperType->refObject(toScriptWrappableBase());
     V8DOMWrapper::associateObjectWithWrapperNonTemplate(this, wrapperType, wrapper, isolate);
-
     DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);
     if (world.isMainWorld() && frame())
         frame()->script().windowProxy(world)->updateDocumentWrapper(wrapper);

[haraken, 2014/09/05 16:41:39]

The line 5876 - 5788 should be put in Document::wrap (after the
Document::associateWithWrapper call).

T::associateWithWrapper should not call anything but refObject and
associateObjectWithWrapperNonTemplate.

BTW, if T::associateWithWrapper always calls refObject and
associateObjectWithWrapperNonTemplate, can we remove all
T::associateWithWrapper's from all subclasses of ScriptWrappable?

[Yuki, 2014/09/08 07:56:05]

As we talked offline, we need two entry points for the case a) we create a new
wrapper from the impl, and case b) JS already created a wrapper object and we'd
like to re-use that wrapper in callback constructors.  The method
T::associateWithWrapper is the entry point for the case b).

I believe that line 5786 - 5788 are (potentially) necessary for the case b),
too, although Document doesn't have a callback constructor.

-
     return wrapper;
 }