Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 542033002: [Local NTP] block image-related context menu items for thumbnails; CSS fixes. (Closed)

Created:
6 years, 3 months ago by huangs
Modified:
6 years, 3 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Local NTP] block image-related context menu items for thumbnails; CSS fixes. In https://chromiumcodereview.appspot.com/473583002/ we removed a 'shadow' element in thumbnail <iframe> to improve customization. A side effect is that this exposes the thumbnail image, thereby alow the user to futilely access the chrome-search://thumb/#/# image below. This CL adds back a transparent "blocker" in front of the thumbnail to restore old behavior. Also making 2 CSS changes to: - Fix fake box text positioning for RTL. - Move top-margin back from #ntp-contents to #logo, for correctness. BUG=411005 Committed: https://crrev.com/552e4158d943c8d5ab58e8fe69d019f5583724c4 Cr-Commit-Position: refs/heads/master@{#293650}

Patch Set 1 #

Patch Set 2 : Sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M chrome/browser/resources/local_ntp/local_ntp.css View 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_thumbnail.css View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_thumbnail.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
huangs
PTAL.
6 years, 3 months ago (2014-09-05 05:01:37 UTC) #2
Mathieu
lgtm
6 years, 3 months ago (2014-09-05 15:10:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/542033002/1
6 years, 3 months ago (2014-09-05 15:11:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9003)
6 years, 3 months ago (2014-09-05 15:20:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/542033002/1
6 years, 3 months ago (2014-09-06 06:50:29 UTC) #11
commit-bot: I haz the power
Failed to apply the patch.
6 years, 3 months ago (2014-09-06 06:51:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/542033002/20001
6 years, 3 months ago (2014-09-06 13:45:52 UTC) #15
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 15:46:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/542033002/20001
6 years, 3 months ago (2014-09-07 03:29:15 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6b3c2817763229771d2bcabf9d6f96b14a42ece6
6 years, 3 months ago (2014-09-07 03:30:20 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:51 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/552e4158d943c8d5ab58e8fe69d019f5583724c4
Cr-Commit-Position: refs/heads/master@{#293650}

Powered by Google App Engine
This is Rietveld 408576698