Issue 54203003: Use TextResourceDecoder for the WebVTTParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54203003: Use TextResourceDecoder for the WebVTTParser (Closed)

Created:
7 years, 1 month ago by fs

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin, jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, nessy, vcarbune.chromium, philipj_slow, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use TextResourceDecoder for the WebVTTParser Simplifies BOM handling, signature detection and fixes handling of "short" (< 9 bytes) inputs. Also fixes the signature checker to allow a formfeed character to follow the signature itself. BUG=231460 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161049

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -40 lines)			Patch
M	LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/track/WebVTTParser.h	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	Source/core/html/track/WebVTTParser.cpp	View	8 chunks	+20 lines, -31 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/54203003/1

7 years, 1 month ago (2013-10-31 10:29:11 UTC) #3

Message was sent while issue was closed.

Change committed as 161049

Expand Messages | Collapse Messages