tests/corelib/bool_from_environment_default_value_test.dart - Issue 54203002: Update documentation on .fromEnvironment. Make bool default be false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/corelib/bool_from_environment_default_value_test.dart

Issue 54203002: Update documentation on .fromEnvironment. Make bool default be false. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix test. Remove reference to throwing from int.fromEnvironment Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/corelib/bool_from_environment_default_value_test.dart

diff --git a/tests/corelib/bool_from_environment_default_value_test.dart b/tests/corelib/bool_from_environment_default_value_test.dart

index 82acf265a02706f223b871cec972d5d3df45f495..f41252238f300526aa5fed7a4f8460db149aea65 100644

--- a/tests/corelib/bool_from_environment_default_value_test.dart

+++ b/tests/corelib/bool_from_environment_default_value_test.dart

@@ -5,7 +5,7 @@

import "package:expect/expect.dart";

main() {

- Expect.isNull(const bool.fromEnvironment('NOT_FOUND'));

+ Expect.isFalse(const bool.fromEnvironment('NOT_FOUND'));

Expect.isTrue(const bool.fromEnvironment('NOT_FOUND', defaultValue: true));

Expect.isFalse(const bool.fromEnvironment('NOT_FOUND', defaultValue: false));

Expect.isNull(const bool.fromEnvironment('NOT_FOUND', defaultValue: null));

« no previous file with comments | « sdk/lib/core/string.dart ('k') | no next file » | no next file with comments »