sdk/lib/_internal/lib/core_patch.dart - Issue 54203002: Update documentation on .fromEnvironment. Make bool default be false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/core_patch.dart

Issue 54203002: Update documentation on .fromEnvironment. Make bool default be false. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix test. Remove reference to throwing from int.fromEnvironment Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/lib/core_patch.dart

diff --git a/sdk/lib/_internal/lib/core_patch.dart b/sdk/lib/_internal/lib/core_patch.dart

index 8e5bec02c81cd96fb813f3328a2c64e52a228ba1..9e1c51f706c1467c15479b9bbb13f974ae99c9b2 100644

--- a/sdk/lib/_internal/lib/core_patch.dart

+++ b/sdk/lib/_internal/lib/core_patch.dart

@@ -232,7 +232,7 @@ patch class String {

}

patch class bool {

- patch factory bool.fromEnvironment(String name, {bool defaultValue}) {

+ patch factory bool.fromEnvironment(String name, {bool defaultValue: false}) {

throw new UnsupportedError(

'bool.fromEnvironement can only be used as a const constructor');

}

« no previous file with comments | « runtime/lib/bool_patch.dart ('k') | sdk/lib/core/bool.dart » ('j') | no next file with comments »