Chromium Code Reviews
Help | Chromium Project | Sign in
(702)

Issue 542005: Hooked demos.gyp and gles_book_examples.gyp to all.gyp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Alok Priyadarshi
Modified:
2 years, 10 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Hooked demos.gyp and gles_book_examples.gyp to all.gyp

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35865

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Lint Patch
M build/all.gyp View 1 chunk +2 lines, -0 lines 2 comments 0 errors Download
Commit:

Messages

Total messages: 4
Alok Priyadarshi
4 years, 3 months ago #1
Alok Priyadarshi
4 years, 3 months ago #2
apatrick
LGTM http://codereview.chromium.org/542005/diff/1/2 File build/all.gyp (right): http://codereview.chromium.org/542005/diff/1/2#newcode99 build/all.gyp:99: '../gpu/demos/demos.gyp:*', It looks like these are in alphabetical ...
4 years, 3 months ago #3
Alok Priyadarshi
4 years, 3 months ago #4
http://codereview.chromium.org/542005/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/542005/diff/1/2#newcode99
build/all.gyp:99: '../gpu/demos/demos.gyp:*',
On 2010/01/09 03:57:08, apatrick wrote:
> It looks like these are in alphabetical order, in which case demos.gyp should
be
> one line up.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6