Source/core/html/HTMLInputElement.cpp - Issue 541993003: Generate focusin for input type=date/time when selected by tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 541993003: Generate focusin for input type=date/time when selected by tab (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated tests and removed handleFocusInEvent handler Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-focusin-event.html ('K') | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 253c04bd2f005c3d7b92a0c8d353b10a9c39e963..47072cdf537590ad4f4b121248b7a37ab931881c 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -388,6 +388,13 @@ void HTMLInputElement::handleFocusEvent(Element* oldFocusedElement, FocusType ty

m_inputType->enableSecureTextInput();

}

+void HTMLInputElement::dispatchFocusInEvent(const AtomicString& eventType, Element* oldFocusedElement, FocusType type)

+ if (eventType == EventTypeNames::DOMFocusIn)

tkent 2014/09/11 23:52:55 Two spaces after == should be one.

Habib Virji 2014/09/12 08:18:25 Done.

+ m_inputTypeView->handleFocusInEvent(oldFocusedElement, type);

+ HTMLFormControlElementWithState::dispatchFocusInEvent(eventType, oldFocusedElement, type);

void HTMLInputElement::handleBlurEvent()

{

m_inputType->disableSecureTextInput();