athena: Move the USE_ATHENA define into //chrome.

athena: Move the USE_ATHENA define into //chrome.

Switching the use_athena gyp-flag only affects the code inside //chrome. So move
the USE_ATHENA inside //chrome so that toggling the flag doesn't cause all
targets to be rebuilt, and only code inside //chrome is rebuilt instead. This
should also prevent accidental dependence on USE_ATHENA in code outside of
//chrome.

BUG=none
R=oshima@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/ec96ebfa63de8e17aaf9ec496a5c70c0e085edb7

[sadrul, 2014-09-05 03:21:02]

sadrul@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2014-09-05 14:27:09]

On 2014/09/05 03:21:02, sadrul wrote:

Is it possible to define in chrome.gyp so that we don't have to do this in each
gypi?
If not, then lgtm

[sadrul, 2014-09-05 15:44:47]

On 2014/09/05 14:27:09, oshima wrote:
> On 2014/09/05 03:21:02, sadrul wrote:
> 
> Is it possible to define in chrome.gyp so that we don't have to do this in
each
> gypi?

I tried doing that at first, but it doesn't look like that's possible, e.g. even
adding 'defines': ['USE_ATHENA=1'] in chrome.gyp unconditionally doesn't build
for athena.

> If not, then lgtm

[sadrul, 2014-09-05 19:18:49]

Committed patchset #1 (id:1) manually as ec96ebf (presubmit successful).

[commit-bot: I haz the power, 2014-09-10 03:41:06]

Patchset 1 (id:??) landed as
https://crrev.com/ec96ebfa63de8e17aaf9ec496a5c70c0e085edb7
Cr-Commit-Position: refs/heads/master@{#293566}