Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 541953002: GN rules for libwebp dsp neon stuff (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, urvang (Google), jzern, skal, vikasa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN rules for libwebp dsp neon stuff This stuff is needed to get blink linking in android. R=brettw@chromium.org,fbarchard@chromium.org Committed: https://crrev.com/4a8306fe12d1b048f74a769c8bb55d6715eac1b1 Cr-Commit-Position: refs/heads/master@{#293668}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -39 lines) Patch
M third_party/libwebp/BUILD.gn View 1 5 chunks +36 lines, -39 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
jamesr
6 years, 3 months ago (2014-09-05 00:47:57 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-05 18:03:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/541953002/1
6 years, 3 months ago (2014-09-05 18:05:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2528)
6 years, 3 months ago (2014-09-05 19:01:19 UTC) #7
urvang (Google)
https://codereview.chromium.org/541953002/diff/1/third_party/libwebp/BUILD.gn File third_party/libwebp/BUILD.gn (right): https://codereview.chromium.org/541953002/diff/1/third_party/libwebp/BUILD.gn#newcode193 third_party/libwebp/BUILD.gn:193: # TODO(GYP): Remove this line?
6 years, 3 months ago (2014-09-05 19:11:59 UTC) #9
jamesr
https://codereview.chromium.org/541953002/diff/1/third_party/libwebp/BUILD.gn File third_party/libwebp/BUILD.gn (right): https://codereview.chromium.org/541953002/diff/1/third_party/libwebp/BUILD.gn#newcode193 third_party/libwebp/BUILD.gn:193: # TODO(GYP): On 2014/09/05 19:11:58, urvang (Google) wrote: > ...
6 years, 3 months ago (2014-09-05 19:24:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/541953002/20001
6 years, 3 months ago (2014-09-05 19:29:28 UTC) #12
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 01:31:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/541953002/20001
6 years, 3 months ago (2014-09-06 06:16:10 UTC) #16
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 10:52:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/541953002/20001
6 years, 3 months ago (2014-09-07 22:23:20 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 66c4b258dd4e605d66f9a6cbb8f3b61d8c8ad1fe
6 years, 3 months ago (2014-09-07 22:24:34 UTC) #21
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:25 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a8306fe12d1b048f74a769c8bb55d6715eac1b1
Cr-Commit-Position: refs/heads/master@{#293668}

Powered by Google App Engine
This is Rietveld 408576698