Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 541943003: ServiceWorker: Remove navigator.serviceWorker.{installing,waiting,active} (Blink) (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
tkent, horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Remove navigator.serviceWorker.{installing,waiting,active} (Blink) These attributes are gone: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container Chromium: https://codereview.chromium.org/544023002/ BUG=404982 TEST=run_webkit_tests.py --debug http/tests/serviceworker/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181534

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix test #

Patch Set 3 : update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -80 lines) Patch
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/serviceworker/serviceworkercontainer-interface.html View 1 1 chunk +2 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 3 chunks +0 lines, -9 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 3 chunks +9 lines, -39 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M public/platform/WebServiceWorkerProviderClient.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
nhiroki
Hi, can you review this? Thanks!
6 years, 3 months ago (2014-09-05 06:59:10 UTC) #2
tkent
lgtm https://codereview.chromium.org/541943003/diff/1/Source/modules/serviceworkers/ServiceWorkerContainer.cpp File Source/modules/serviceworkers/ServiceWorkerContainer.cpp (right): https://codereview.chromium.org/541943003/diff/1/Source/modules/serviceworkers/ServiceWorkerContainer.cpp#newcode200 Source/modules/serviceworkers/ServiceWorkerContainer.cpp:200: void ServiceWorkerContainer::setController(WebServiceWorker* serviceWorker) nit: please don't move unaffected ...
6 years, 3 months ago (2014-09-05 07:43:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/541943003/1
6 years, 3 months ago (2014-09-05 07:44:13 UTC) #5
horo
lgtm
6 years, 3 months ago (2014-09-05 10:30:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/541943003/1
6 years, 3 months ago (2014-09-05 14:35:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/23645)
6 years, 3 months ago (2014-09-05 15:36:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/541943003/40001
6 years, 3 months ago (2014-09-05 16:33:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/23666)
6 years, 3 months ago (2014-09-05 17:35:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/541943003/40001
6 years, 3 months ago (2014-09-05 17:45:01 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/23677)
6 years, 3 months ago (2014-09-05 18:52:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/541943003/60001
6 years, 3 months ago (2014-09-08 01:45:37 UTC) #22
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 02:45:34 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as 181534

Powered by Google App Engine
This is Rietveld 408576698