Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 541933003: GN: Update heap stubs for android (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

GN: Update heap stubs for android On non-intel (aka non x86/x64) we can compile the assembly stubs as a source_set and not use yasm. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181529

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : put it all in S/p/h/asm #

Patch Set 4 : fix paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -46 lines) Patch
M Source/platform/BUILD.gn View 1 2 3 chunks +0 lines, -33 lines 0 comments Download
M Source/platform/heap/BUILD.gn View 1 2 1 chunk +1 line, -9 lines 0 comments Download
A Source/platform/heap/asm/BUILD.gn View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
M public/BUILD.gn View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
jamesr
6 years, 3 months ago (2014-09-05 00:55:50 UTC) #1
jamesr
Oh whoops, these were already in Source/platform/heap/. Huh, wonder why it isn't using yasm for ...
6 years, 3 months ago (2014-09-05 00:58:52 UTC) #2
jamesr
Oh, the one in Source/platform/heap/ probably does nothing on x86/x64 since the .S file won't ...
6 years, 3 months ago (2014-09-05 00:59:31 UTC) #3
jamesr
https://codereview.chromium.org/541933003/diff/20001/Source/platform/heap/BUILD.gn File Source/platform/heap/BUILD.gn (left): https://codereview.chromium.org/541933003/diff/20001/Source/platform/heap/BUILD.gn#oldcode19 Source/platform/heap/BUILD.gn:19: if (cpu_arch == "x86" || cpu_arch == "x64") { ...
6 years, 3 months ago (2014-09-05 01:01:52 UTC) #4
jamesr
On further thought I think hiding all this in Source/platform/heap/asm/BUILD.gn makes even more sense. It's ...
6 years, 3 months ago (2014-09-05 17:52:34 UTC) #5
brettw
lgtm
6 years, 3 months ago (2014-09-05 19:48:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/541933003/60001
6 years, 3 months ago (2014-09-05 19:50:09 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 07:48:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/541933003/60001
6 years, 3 months ago (2014-09-07 22:24:13 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-07 22:24:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 181529

Powered by Google App Engine
This is Rietveld 408576698