Move caret to correct position when dir=auto

Move caret to correct position when dir=auto for space and LTR text following RTL text.

In getPositionAndOffset, previous block was used when space is entered for dir=auto. While for dir=auto text using previous block gives wrong caret position, which was leading to caret offset not calculated.  In case of RTL, previous inline box position is used.

Since auto scenario, combines RTL and LTR text. In renderText, only render block direction is used. New condition has been added in RenderText to test if dir=auto, then use inlineBlock bidiLevel to decide about caret position rendering.

R=leviw, eae
BUG=296847
TEST=Direction auto tests covering move caret position to the right when
LTR text is entered and adding RTL text to move caret to the left.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181701

[Habib Virji, 2014-09-04 17:20:28]

habib.virji@samsung.com changed reviewers:
+ aharon@google.com, behdad@google.com

[Habib Virji, 2014-09-04 17:21:26]

Covered the issue raised for aharon for bug296847. Please have a look.

[Habib Virji, 2014-09-08 18:40:31]

On 2014/09/04 17:21:26, Habib Virji wrote:
> Covered the issue raised by aharon for bug296847. 

@eae: Please have a look.

[eae, 2014-09-08 18:58:51]

The change itself makes sense but I don't like the code duplication.

https://codereview.chromium.org/541823003/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderText.cpp (right):

https://codereview.chromium.org/541823003/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderText.cpp:707: left = std::max(left, leftEdge);
The code in this block is identical to that in the block above. Please try to
avoid this level of code duplication.

[Habib Virji, 2014-09-08 19:08:59]

On 2014/09/08 18:58:51, eae wrote:
> The change itself makes sense but I don't like the code duplication.
> 
>
https://codereview.chromium.org/541823003/diff/1/Source/core/rendering/Render...
> File Source/core/rendering/RenderText.cpp (right):
> 
>
https://codereview.chromium.org/541823003/diff/1/Source/core/rendering/Render...
> Source/core/rendering/RenderText.cpp:707: left = std::max(left, leftEdge);
> The code in this block is identical to that in the block above. Please try to
> avoid this level of code duplication.

Thanks for the review, will update code.

[Habib Virji, 2014-09-09 10:44:03]

Thanks Emil, updated to correctly calculate right aligned position. Added
comment to make it explicit it is for direction=auto scenario.

https://codereview.chromium.org/541823003/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderText.cpp (right):

https://codereview.chromium.org/541823003/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderText.cpp:707: left = std::max(left, leftEdge);
On 2014/09/08 18:58:50, eae wrote:
> The code in this block is identical to that in the block above. Please try to
> avoid this level of code duplication.

Done.

[Habib Virji, 2014-09-09 20:48:45]

On 2014/09/09 10:44:03, Habib Virji wrote:
> Thanks Emil, updated to correctly calculate right aligned position. Added
> comment to make it explicit it is for direction=auto scenario.
> 
>
https://codereview.chromium.org/541823003/diff/1/Source/core/rendering/Render...
> File Source/core/rendering/RenderText.cpp (right):
> 
>
https://codereview.chromium.org/541823003/diff/1/Source/core/rendering/Render...
> Source/core/rendering/RenderText.cpp:707: left = std::max(left, leftEdge);
> On 2014/09/08 18:58:50, eae wrote:
> > The code in this block is identical to that in the block above. Please try
to
> > avoid this level of code duplication.
> 
> Done.
@eae are the changes okay?

[eae, 2014-09-09 20:51:01]

LGTM
Much better, thank you.

[Habib Virji, 2014-09-09 20:53:32]

On 2014/09/09 20:51:01, eae wrote:
> LGTM
> Much better, thank you.

Thanks.

[Habib Virji, 2014-09-09 20:53:41]

The CQ bit was checked by habib.virji@samsung.com

[commit-bot: I haz the power, 2014-09-09 20:53:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/habib.virji@samsung.com/541823003/40001

[commit-bot: I haz the power, 2014-09-09 23:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 23:00:05]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26301)

[Habib Virji, 2014-09-10 05:11:58]

The CQ bit was checked by habib.virji@samsung.com

[commit-bot: I haz the power, 2014-09-10 05:12:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/habib.virji@samsung.com/541823003/40001

[commit-bot: I haz the power, 2014-09-10 05:13:14]

Committed patchset #3 (id:40001) as 181701