Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/content_settings/core/common/BUILD.gn

Issue 541813002: Componentize chrome/common/content_settings files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: GN fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/content_settings.gypi ('k') | components/content_settings/core/common/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/common/BUILD.gn
diff --git a/components/content_settings/core/common/BUILD.gn b/components/content_settings/core/common/BUILD.gn
index 6dfa0bb283752821e1146e75a311d418cc583401..6d3d02c97c46aa3ef2fb8a51a786dcef624fc79a 100644
--- a/components/content_settings/core/common/BUILD.gn
+++ b/components/content_settings/core/common/BUILD.gn
@@ -2,12 +2,34 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("common") {
+static_library("common") {
sources = [
+ "content_settings.cc",
+ "content_settings.h",
"content_settings_pattern.cc",
"content_settings_pattern.h",
"content_settings_pattern_parser.cc",
"content_settings_pattern_parser.h",
"content_settings_types.h",
]
+
+ deps = [
+ "//base",
+ "//net",
+ "//url",
+ ]
+}
+
+source_set("unit_tests") {
+ testonly = true
+ sources = [
+ "content_settings_pattern_unittest.cc",
+ "content_settings_pattern_parser_unittest.cc",
+ ]
+
+ deps = [
+ ":common",
+ "//testing/gmock",
+ "//testing/gtest",
+ ]
}
« no previous file with comments | « components/content_settings.gypi ('k') | components/content_settings/core/common/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698