chrome/DEPS - Issue 541813002: Componentize chrome/common/content_settings files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/DEPS

Issue 541813002: Componentize chrome/common/content_settings files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: OWNERS Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+crypto",	2 "+crypto",

3 "+gpu",	3 "+gpu",

4 "+net",	4 "+net",

5 "+printing",	5 "+printing",

6 "+sql",	6 "+sql",

7 # Browser, renderer, common and tests access V8 for various purposes.	7 # Browser, renderer, common and tests access V8 for various purposes.

8 "-v8",	8 "-v8",

9 "+v8/include",	9 "+v8/include",

10	10

11 # Limit what we include from nacl.	11 # Limit what we include from nacl.

12 "-native_client",	12 "-native_client",

13	13

14 # The subdirectories in chrome/ will manually allow their own include	14 # The subdirectories in chrome/ will manually allow their own include

15 # directories in chrome/ so we disallow all of them.	15 # directories in chrome/ so we disallow all of them.

16 "-chrome",	16 "-chrome",

17 "+chrome/common",	17 "+chrome/common",

18 "+chrome/test",	18 "+chrome/test",

	19 "+components/content_settings",
	vabr (Chromium) 2014/09/04 20:02:51 Is this just a temporary? If so, should there be a Is this just a temporary? If so, should there be a TODO stating when it's OK to remove? If it's not temporary, could this be in subdirectories, which need this instead? Jun Mukai 2014/09/04 23:50:40 Good catch. This is note temporary, but indeed thi Show quoted text On 2014/09/04 20:02:51, vabr (Chromium) wrote: > Is this just a temporary? If so, should there be a TODO stating when it's OK to > remove? If it's not temporary, could this be in subdirectories, which need this > instead? Good catch. This is note temporary, but indeed this must be content_settings/core/common.
19 "+components/url_fixer",	20 "+components/url_fixer",

20 "+components/variations",	21 "+components/variations",

21 "+content/public/common",	22 "+content/public/common",

22 "+content/public/test",	23 "+content/public/test",

23 "+mojo/common",	24 "+mojo/common",

24 "+mojo/public",	25 "+mojo/public",

25	26

26 # Don't allow inclusion of these other libs we shouldn't be calling directly.	27 # Don't allow inclusion of these other libs we shouldn't be calling directly.

27 "-webkit",	28 "-webkit",

28 "-tools",	29 "-tools",

29	30

30 "-crypto/third_party",	31 "-crypto/third_party",

31	32

32 # Allow inclusion of WebKit API files.	33 # Allow inclusion of WebKit API files.

33 "+third_party/WebKit/public/platform",	34 "+third_party/WebKit/public/platform",

34 "+third_party/WebKit/public/web",	35 "+third_party/WebKit/public/web",

35	36

36 # Allow inclusion of third-party code:	37 # Allow inclusion of third-party code:

37 "+third_party/hunspell",	38 "+third_party/hunspell",

38 "+third_party/libxml",	39 "+third_party/libxml",

39 "+third_party/skia",	40 "+third_party/skia",

40	41

41 "+ui",	42 "+ui",

42 ]	43 ]

OLD	NEW

« no previous file with comments | « WATCHLISTS ('k') | chrome/app/chrome_main_delegate.cc » ('j') | components/content_settings/core/common/DEPS » ('J')