components/feedback/tracing_manager.h - Issue 541763002: tracing: get rid of files in TracingController interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feedback/tracing_manager.h

Issue 541763002: tracing: get rid of files in TracingController interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased, fixed tests following last ps Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/feedback/tracing_manager.h

diff --git a/components/feedback/tracing_manager.h b/components/feedback/tracing_manager.h

index 1148a1c9f899890dd073dc05ec64493763f351be..e846f379292afc5d335652f4cb1b5de8a33bedcd 100644

--- a/components/feedback/tracing_manager.h

+++ b/components/feedback/tracing_manager.h

@@ -58,7 +58,7 @@ class TracingManager {

TracingManager();

void StartTracing();

- void OnTraceDataCollected(const base::FilePath& path);

+ void OnTraceDataCollected(base::RefCountedString* data);

// ID of the trace that is being collected.

int current_trace_id_;

« no previous file with comments | « no previous file | components/feedback/tracing_manager.cc » ('j') | content/public/browser/tracing_controller.h » ('J')