Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: content/browser/devtools/devtools_tracing_handler.h

Issue 541763002: tracing: get rid of files in TracingController interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed android Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_tracing_handler.h
diff --git a/content/browser/devtools/devtools_tracing_handler.h b/content/browser/devtools/devtools_tracing_handler.h
index fe270bd847264bd4eb3283885a8cf0bce90af6ae..fa6b7b69a16e5f591ad351ca8b5d8468a6f0cc63 100644
--- a/content/browser/devtools/devtools_tracing_handler.h
+++ b/content/browser/devtools/devtools_tracing_handler.h
@@ -33,10 +33,11 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler {
void EnableTracing(const std::string& category_filter);
void DisableTracing();
- private:
- void BeginReadingRecordingResult(const base::FilePath& path);
- void ReadRecordingResult(const scoped_refptr<base::RefCountedString>& result);
+
void OnTraceDataCollected(const std::string& trace_fragment);
+ void OnTraceComplete();
+
+ private:
void OnRecordingEnabled(scoped_refptr<DevToolsProtocol::Command> command);
void OnBufferUsage(float usage);
@@ -55,9 +56,7 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler {
void SetupTimer(double usage_reporting_interval);
- void DisableRecording(
- const TracingController::TracingFileResultCallback& callback =
- TracingController::TracingFileResultCallback());
+ void DisableRecording(bool abort);
base::WeakPtrFactory<DevToolsTracingHandler> weak_factory_;
scoped_ptr<base::Timer> buffer_usage_poll_timer_;

Powered by Google App Engine
This is Rietveld 408576698